Skip to content

chore: use circleci orb 3 #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 1, 2023
Merged

chore: use circleci orb 3 #591

merged 13 commits into from
Mar 1, 2023

Conversation

jordanpowell88
Copy link
Contributor

This PR refactors CI to use the CircleCI Orb v3

@CLAassistant
Copy link

CLAassistant commented Feb 28, 2023

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Feb 28, 2023

Deploy Preview for cypress-example-kitchensink ready!

Name Link
🔨 Latest commit f4610aa
🔍 Latest deploy log https://app.netlify.com/sites/cypress-example-kitchensink/deploys/63ffb45318a94b00082f3a5e
😎 Deploy Preview https://deploy-preview-591--cypress-example-kitchensink.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cypress
Copy link

cypress bot commented Feb 28, 2023

Passing run #23694 ↗︎

0 124 0 0 Flakiness 0

Details:

chore: remove mac from linux requires
Project: cypress-example-kitchensink Commit: f4610aaf86
Status: Passed Duration: 05:48 💡
Started: Mar 1, 2023 8:45 PM Ended: Mar 1, 2023 8:51 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@cypress
Copy link

cypress bot commented Feb 28, 2023

Passing run #23665 ↗︎

0 124 0 0 Flakiness 0

Details:

Merge 602d79e into 3aaf357...
Project: cypress-example-kitchensink Commit: 06bf8183d8 ℹ️
Status: Passed Duration: 03:46 💡
Started: Mar 1, 2023 8:26 PM Ended: Mar 1, 2023 8:30 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@jordanpowell88 jordanpowell88 changed the title ref: use circleci orb 3 chore: use circleci orb 3 Feb 28, 2023
@jordanpowell88 jordanpowell88 marked this pull request as ready for review February 28, 2023 21:03
@@ -8,13 +8,9 @@
version: 2.1
orbs:
# use Cypress orb from CircleCI registry
cypress: cypress-io/[email protected]
cypress: cypress-io/cypress@3

executors:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does removing the Mac distinction mean for this? I don't know if the naming, etc was tracked for anything in the CircleCI dashboard.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am essentially telling it to use our executor instead of the mac machine wired up here

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get that part. I just mean I wasn't sure what ramifications that has. Like, was that mac distinction meaningful for anything...maybe in the reporting in the dashboard or something?

@jordanpowell88 jordanpowell88 merged commit 120055d into master Mar 1, 2023
@jordanpowell88 jordanpowell88 deleted the update-circleci-orb branch March 1, 2023 20:35
@cypress-app-bot
Copy link
Collaborator

🎉 This PR is included in version 1.16.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants