-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chore: use circleci orb 3 #591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for cypress-example-kitchensink ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Passing run #23694 ↗︎Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Passing run #23665 ↗︎Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
afe4c5f
to
44705ad
Compare
@@ -8,13 +8,9 @@ | |||
version: 2.1 | |||
orbs: | |||
# use Cypress orb from CircleCI registry | |||
cypress: cypress-io/[email protected] | |||
cypress: cypress-io/cypress@3 | |||
|
|||
executors: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does removing the Mac
distinction mean for this? I don't know if the naming, etc was tracked for anything in the CircleCI dashboard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am essentially telling it to use our executor instead of the mac
machine wired up here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get that part. I just mean I wasn't sure what ramifications that has. Like, was that mac distinction meaningful for anything...maybe in the reporting in the dashboard or something?
🎉 This PR is included in version 1.16.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR refactors CI to use the CircleCI Orb
v3