Windows build #482
Merged
Windows build #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adding read distribution * revert formattings * Updating docker file to activate pyenv * Activate PyEnv * Adding cylon user * Adding examples section to the readme * Adding the shared folder for application source * adding data split test case * deleting temp file created in tmp directory * changed test all command * adding --with-mpi * removed --with-mpi * adding descriptions for examples * adding blogs to the website * taking file open out of numpy * fixing the test to use mpi * adding barrier * windows build * removed redundant glog lib * build.py adding CPP build * more windows changes * handeling python command in windows and linux * temporary changes * Documentation update (#479) * updating the conda install command * updating the conda install command Co-authored-by: Supun Kamburugamuve <[email protected]>
# Conflicts: # cpp/CMake/Modules/ConfigureArrow.cmake # cpp/CMakeLists.txt
nirandaperera
approved these changes
Sep 8, 2021
| {CMAKE_FLAGS} {CPP_SOURCE_DIR}' | ||
|
|
||
| print(cmake_command, BUILD_DIR) | ||
| res = subprocess.call(cmake_command, cwd=BUILD_DIR, shell=True) |
There was a problem hiding this comment.
don't we have to forward the environment variables to the subprocess here? expecially in the conda environment?
There was a problem hiding this comment.
I think we don't need to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.