Bump supported kubernetes from 1.31 to 1.33 #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkwmt
force-pushed
the
k8s-1.33
branch
6 times, most recently
from
0cf1e73 to
c4516bc
Compare
takahiro-yamada
requested changes
Jun 27, 2025
test/e2e/e2e_test.go
Outdated
| @@ -238,7 +238,8 @@ var _ = Describe("controller", Ordered, func() { | |||
|
|
|||
| // login to target-sts-0 Pod using `kubectl exec` | |||
| go func() { | |||
| _, err := utils.Kubectl(ptmx, "exec", "target-sts-0", "-it", "--", "sleep", fmt.Sprintf("%d", 3*testIntervalSeconds+2)) | |||
| // subsequent tests may take some time, so sleep longer duration | |||
| _, err := utils.Kubectl(ptmx, "exec", "target-sts-0", "-it", "--", "sleep", "180") | |||
There was a problem hiding this comment.
180 is a magic number, so how about commonizing with the arg of WithTimeout?
It looks hard to get what the number means.
There was a problem hiding this comment.
This is the time it takes to pull ubuntu-debug image.
zoetrope
reviewed
Jun 27, 2025
cmd/login-protector/main.go
Outdated
| Client: mgr.GetClient(), | ||
| ClientSet: kubernetes.NewForConfigOrDie(mgr.GetConfig()), | ||
| Scheme: mgr.GetScheme(), | ||
| RequeueRateLimiter: workqueue.NewTypedItemExponentialFailureRateLimiter[ctrl.Request](1*time.Second, 1000*time.Second), |
There was a problem hiding this comment.
The following PR says that the ceiling is too high.
kubernetes-sigs/controller-runtime#3107 (comment)
I think about 300 seconds is appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:
Result.RequeueRequeueAfterwith exponential backoff instead ofRequeueaqua.yamlgolangci-lint migrateto support v2 and fix lint errors