[WIP] Add about cvat decription and version number #944
Conversation
| (): void => { | ||
| const t = localStorage.getItem('token'); | ||
| const token ='Token '+ t.replace(/['"]+/g, '') | ||
| const data = axios.get(`${serverHost}/api/v1/server/about`,{ headers: {Authorization : token}}).then( |
There was a problem hiding this comment.
We shouldn't make server requests here.
There are two problems:
- To be consistent and do not do extra requests, we should use
reduxhere (create reducer [for example ServerInfoReducer], add it to CVAT storage, add some actions for the reducer) and provide some props from the storage to the component. Look for example how we get users (usersReducer, usersActions) in such a scheme. - You do not need to do request manually with axios and add an authorization token. Just use cvat-core to get this data:
const core = getCore();
core.server.about()| @@ -62,6 +67,34 @@ function HeaderContainer(props: Props): JSX.Element { | |||
| > | |||
| Tasks | |||
| </Button> | |||
| <Popover placement="bottom" title={content} content={text} trigger="click" overlayStyle={{width : "50vw"}}> | |||
There was a problem hiding this comment.
I agree with you about it should be a switchable window, but this component doesn't look pretty.
I believe a Modal window would be great here.
You know, a tool name, an image, description, a version, the github link, etc.
There was a problem hiding this comment.
Hi, @bsekachev
What image do you want to include here?
As of now, I have the tool name, version number and description (in the same order). Also, I believe adding a github link would make it redundant as it already appears on the header. Kindly let me know about these. Thanks :)
There was a problem hiding this comment.
Hi, @LiSa20120
To be honest, I don't know what image can we use here. Probably it's better to skip this moment for now.
I have some ideas about content of the dialog window:
- The name of the tool
- Tool description
- Server version (can get via core.server.about())
- Core version (can get via core.client.version)
- Release notes ("what's new") (just a link to the section of the
CHANGELOG.mdfile) - License information (a link to
LICENSEfile in the repository) - "Need help?" (a link to the gitter chat)
- Maybe link to Forum on Intel Developer Zone
@nmanovic, what do you think?
There was a problem hiding this comment.
@bsekachev Have a look at it.
There was a problem hiding this comment.
@bsekachev How are you converting the md files to html?
Should we install react-markdown?
| } | ||
| } | ||
| > | ||
| About |
There was a problem hiding this comment.
I believe the best place to put this button is menu in header (near with logout button).
|
Hi, good work. |
|
A couple additional comments. |
nmanovic
changed the title
|
@LiSa20120 , please look at the PR from Boris: #963. It has
|
|
@bsekachev Thank you. |
|
Hi @LiSa20120 , I will close the PR for now. Please don't hesitate to reopen it when you are ready. |
Added section for version number
before clicking
after clicking
