Review and update the Domestic Fallback Rates as needed, and eliminate the International Fallback Rates. #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Went digging to find where this was used, and I think I may have found our source of international confusion in Vertex: |
jcain3389
force-pushed
the
dwheeler/vertex-client-cleanup
branch
from
affba34 to
88c1c96
Compare
jcain3389
force-pushed
the
dwheeler/vertex-client-cleanup
branch
from
1d69daf to
7f64b85
Compare
jcain3389
force-pushed
the
dwheeler/vertex-client-cleanup
branch
from
7f64b85 to
7552ba6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stakeholder Overview (learn more)
We recently sorted out with Finance that we should not be charging sales tax for any internationally shipping orders across the business. This included a change to our Vertex configurations to always return 0% tax for all international orders.
However, our vertex_client gem used to interact with the Vertex service had built in fallback tax rates used when the Vertex service is unreachable. Since we should not be collecting international sales tax in any situation, those fallback rates for international country codes were removed in the latest version of the vertex_client gem.
Also included was a review and adjustment of the existing fallback tax rates for domestic states/regions.
Risk Estimate (learn more)
Affects all users of the vertex_client gem - with some apps requiring updates to the gem spanning multiple versions with potentially breaking changes
Changes
Project Link
https://customink.monday.com/boards/5878799126/views/145144853/pulses/7956168613