Skip to content

Advanced boolean parsing. Fixes #2095 #2097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 26, 2020
Merged

Advanced boolean parsing. Fixes #2095 #2097

merged 7 commits into from
Aug 26, 2020

Conversation

aslakhellesoy
Copy link
Contributor

This fixes #2095

The value of a system property/enviromnent variable will resolve to true unless it's empty, false, no or 0.

@coveralls
Copy link

coveralls commented Aug 20, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 86.198% when pulling 6a1080e on advanced-boolean-properties into 8477e65 on main.

@cbliard
Copy link
Contributor

cbliard commented Aug 20, 2020

LGTM

@mpkorstanje mpkorstanje mentioned this pull request Aug 23, 2020
Closed
@mpkorstanje
Changes:
4272e88 
1. Empty string will result in an illegal argument exception
2. Using any value other then true/false 1/0 or on/off will result in an illegal argument exception
3. `CucumberEngineOptions` delegates to JUnit 5 via `getBoolean`
4. This (strictly parsing booleans) is a new feature.
@mpkorstanje
Copy link
Contributor

Pushed the conclusion from #2095 onto this branch as well as some minor improvements.

mpkorstanje
mpkorstanje approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge.

@aslakhellesoy don't forget the commit message and bump the minor version before release (mvn versions:set).

@cbliard cbliard merged commit d3f7956 into main Aug 26, 2020
@cbliard cbliard deleted the advanced-boolean-properties branch August 26, 2020 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpkorstanje mpkorstanje mpkorstanje approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow more truthy values for CUCUMBER_PUBLISH_ENABLED
4 participants
@aslakhellesoy @coveralls @cbliard @mpkorstanje