Updating Gherkin version #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Altering Rakefiles to include rubygems.
would be better to have locale set on an higher level, for instance Feature.
christianbellinaef
added a commit
to christianbellinaef/cucumber-jvm
that referenced
this pull request
May 16, 2017
mpkorstanje
added a commit
that referenced
this pull request
Jun 20, 2017
* Fixed complex type writer and added tests. * [Core] Add explicit error message to ComplexTypeWriter When dealing with nested complex types, the ComplexTypeWriter would produce unbalanced and misaligned tables. This could be resolved by adding an `@XStreamConverter` to the complex field but this was not obvious. By adding an explicit exception this is resolved. For ease of use this exception is not thrown when acomplex field is empty or not included in the table .
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to update gherkin version to 2.4.2 in order to compile core, was getting this compilation errors:
/home/cedric/src/cucumber-jvm/core/src/main/java/cucumber/junit/ScenarioRunner.java:[69,19] cucumber.junit.ScenarioRunner.JUnitReporter is not abstract and does not override abstract method nextRow() in gherkin.formatter.Reporter
/home/cedric/src/cucumber-jvm/core/src/main/java/cucumber/junit/ScenarioRunner.java:[91,26] cannot find symbol
symbol : method getError()
location: class gherkin.formatter.model.Result
/home/cedric/src/cucumber-jvm/core/src/main/java/cucumber/junit/ScenarioRunner.java:[92,54] cannot find symbol
symbol : method getError()
location: class gherkin.formatter.model.Result
/home/cedric/src/cucumber-jvm/core/src/main/java/cucumber/runtime/StepDefinitionMatch.java:[28,63] cannot find symbol
symbol : method getStackTraceElement(java.lang.String)
location: class gherkin.formatter.model.Step
/home/cedric/src/cucumber-jvm/core/src/main/java/cucumber/runtime/StepDefinitionMatch.java:[30,42] cannot find symbol
symbol : method getStackTraceElement(java.lang.String)
location: class gherkin.formatter.model.Step
/home/cedric/src/cucumber-jvm/core/src/main/java/cucumber/runtime/World.java:[42,50] cannot find symbol
symbol : variable PASSED
location: class gherkin.formatter.model.Result
/home/cedric/src/cucumber-jvm/core/src/main/java/cucumber/runtime/World.java:[42,66] cannot find symbol
symbol : variable FAILED
location: class gherkin.formatter.model.Result
/home/cedric/src/cucumber-jvm/core/src/main/java/cucumber/runtime/World.java:[43,32] cannot find symbol
symbol : constructor Result(java.lang.String,long,java.lang.Throwable)
location: class gherkin.formatter.model.Result
Next step for me will be to implement base Transformers in order to have calculator feature working...