Skip to content

Sprint 24 #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 22, 2025
Merged

Sprint 24 #813

merged 4 commits into from
May 22, 2025

Conversation

jlkravitz
Copy link
Collaborator

@jlkravitz jlkravitz commented May 21, 2025

  • stand up the site locally
    • test all functionality in all major browsers, emphasizing the functionality that this pull request addresses
      • for public-facing functionality, test in browsers consistent with public browser use data
      • test in Mobile Safari and Mobile Chrome
    • use an automated audit tool for code quality and practices (recommended: Chrome DevTools, aka Lighthouse)
      • look at efficiency of page loads, asset sizes, HTTP connection management, etc.
    • review for accessibility
      • use an automated audit tool, such as Chrome Audit or aXe
      • navigate site only with the keyboard
      • use VoiceOver or Narrator to navigate the site with audio only, with the display turned off
      • manually test anything that pa11y cannot test automatically (e.g., contrast of text over images)
  • review static code analysis results, if available
  • run a security audit of dependencies (e.g. npm audit and pip audit) to ensure that there are no vulnerabilities that will be deployed to production (as opposed to vulnerabilities that only have an impact on the development environment)
  • examine OWASP ZAP output to ensure that any errors are known to be false positives or have been previously declared to be acceptable
  • for each feature-level bug (i.e., it’s working as designed, but designed wrong), open a new issue and put it in the backlog

ChiefStief and others added 3 commits May 9, 2025 09:58
### Testing List
- Smoke tests 
- For API configuration changes: CDK tests added/updated in
`backend/compact-connect/tests/unit/test_api.py`
- Functional/unit tests
- Code review

Closes #783 


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Added staff user API endpoints for retrieving and updating compact and
jurisdiction configurations.
- Introduced detailed API models and schemas with enhanced validation
for compact and jurisdiction management.
- Added smoke tests verifying compact and jurisdiction configuration API
functionality.
- Provided utilities for managing compact and jurisdiction data and
active member jurisdictions.

- **Enhancements**
- Replaced environment-based YAML filtering with centralized JSON
configuration from CDK context.
- Replaced military discount with military rate on privilege fees for
clearer fee handling.
- Improved license type abbreviation validation with duplicate detection
and completeness checks.
- Extended deployment documentation with AWS service quota increase
instructions.
- Simplified licensee registration flags from environment lists to
booleans across configurations and validations.

- **Bug Fixes**
- Improved Python test execution by enhanced module cleanup to prevent
state leakage between tests.

- **Refactor**
- Refocused configuration upload logic to handle attestations and active
jurisdiction data only.
- Removed deprecated military discount code and related legacy
configuration files.
  - Adjusted import paths for constants and schemas.
- Removed environment-specific filtering for active compacts and
jurisdictions, relying on static CDK context.
- Removed legacy migration scripts related to military waiver,
multi-license, and license status fields.
  - Streamlined test data generation and setup utilities.
- Updated compact and jurisdiction data models to new data classes with
serialization and validation improvements.
- Deprecated legacy schema classes in favor of modern data class
implementations.

- **Style**
- Upgraded dependency versions across multiple requirements files for
security and compatibility.

- **Tests**
- Added comprehensive unit, integration, and smoke tests for new API
endpoints and configuration features.
- Removed obsolete tests and test data related to deprecated
configuration files and formats.
- Improved test setup by dynamically loading active member jurisdictions
from centralized configuration.
- Refactored and consolidated test helpers for configuration data
generation and loading.
- Enhanced schema validation tests to check for negative fee amounts and
data integrity.

- **Chores**
- Updated test fixtures and resource files to reflect new configuration
structure and naming conventions.
- Corrected comments and import statements in requirements files and
code modules.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Copy link
Contributor

coderabbitai bot commented May 21, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Our ZAP scan tests failed due to invalid compact/jurisdiction path
parameters causing 502s in our API. This adds needed validation for
those path parameters.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Improved input validation for compact and jurisdiction abbreviations
in several API endpoints, ensuring more informative error messages and
consistent error handling for invalid inputs.

- **Tests**
- Added new tests to verify that API endpoints correctly return errors
when provided with invalid compact or jurisdiction abbreviations.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@jlkravitz
Copy link
Collaborator Author

@isabeleliassen This is good to merge (with a merge commit, rather than a squash & merge). I left one comment unresolved to make sure you saw it, but feel free to resolve it when you've read it. Thanks!

@isabeleliassen isabeleliassen merged commit b51f84d into main May 22, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants