-
Notifications
You must be signed in to change notification settings - Fork 5
Sprint 24 #813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sprint 24 #813
Conversation
### Testing List - Smoke tests - For API configuration changes: CDK tests added/updated in `backend/compact-connect/tests/unit/test_api.py` - Functional/unit tests - Code review Closes #783 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Added staff user API endpoints for retrieving and updating compact and jurisdiction configurations. - Introduced detailed API models and schemas with enhanced validation for compact and jurisdiction management. - Added smoke tests verifying compact and jurisdiction configuration API functionality. - Provided utilities for managing compact and jurisdiction data and active member jurisdictions. - **Enhancements** - Replaced environment-based YAML filtering with centralized JSON configuration from CDK context. - Replaced military discount with military rate on privilege fees for clearer fee handling. - Improved license type abbreviation validation with duplicate detection and completeness checks. - Extended deployment documentation with AWS service quota increase instructions. - Simplified licensee registration flags from environment lists to booleans across configurations and validations. - **Bug Fixes** - Improved Python test execution by enhanced module cleanup to prevent state leakage between tests. - **Refactor** - Refocused configuration upload logic to handle attestations and active jurisdiction data only. - Removed deprecated military discount code and related legacy configuration files. - Adjusted import paths for constants and schemas. - Removed environment-specific filtering for active compacts and jurisdictions, relying on static CDK context. - Removed legacy migration scripts related to military waiver, multi-license, and license status fields. - Streamlined test data generation and setup utilities. - Updated compact and jurisdiction data models to new data classes with serialization and validation improvements. - Deprecated legacy schema classes in favor of modern data class implementations. - **Style** - Upgraded dependency versions across multiple requirements files for security and compatibility. - **Tests** - Added comprehensive unit, integration, and smoke tests for new API endpoints and configuration features. - Removed obsolete tests and test data related to deprecated configuration files and formats. - Improved test setup by dynamically loading active member jurisdictions from centralized configuration. - Refactored and consolidated test helpers for configuration data generation and loading. - Enhanced schema validation tests to check for negative fee amounts and data integrity. - **Chores** - Updated test fixtures and resource files to reflect new configuration structure and naming conventions. - Corrected comments and import statements in requirements files and code modules. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Our ZAP scan tests failed due to invalid compact/jurisdiction path parameters causing 502s in our API. This adds needed validation for those path parameters. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Improved input validation for compact and jurisdiction abbreviations in several API endpoints, ensuring more informative error messages and consistent error handling for invalid inputs. - **Tests** - Added new tests to verify that API endpoints correctly return errors when provided with invalid compact or jurisdiction abbreviations. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
@isabeleliassen This is good to merge (with a merge commit, rather than a squash & merge). I left one comment unresolved to make sure you saw it, but feel free to resolve it when you've read it. Thanks! |
npm audit
andpip audit
) to ensure that there are no vulnerabilities that will be deployed to production (as opposed to vulnerabilities that only have an impact on the development environment)