Skip to content

Frontend/Fix license list edge cases #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jsandoval81
Copy link
Collaborator

Requirements List

  • None

Description List

  • Fixed page-advance breaking after detail view
  • Better handle edge case of cache getting cleared on detail view

Testing List

  • yarn test:unit:all should run without errors or warnings
  • yarn serve should run without errors or warnings
  • yarn build should run without errors or warnings
  • Code review
  • License search
    • As Staff user, perform a license search that will result in multiple pages of licensees
    • Click on a result row to be navigated to the licensee detail page
    • Return to the list page
    • Attempt to advance to next pages
    • Regression: Make sure full license search / results / view flow still works stably

Closes #604

@jsandoval81
Copy link
Collaborator Author

@jlkravitz This is ready for your review.

@jlkravitz
Copy link
Collaborator

jlkravitz commented Feb 26, 2025

@jsandoval81 Looks good. One question– if I'm reading the code correctly, every time a user clicks on a detail page, then navigates back, they will be brought to the search page instead of the results page that they were navigating. True? Probably not in scope for this PR, but isn't that a bit unintuitive?

@jlkravitz jlkravitz mentioned this pull request Feb 26, 2025
15 tasks
@jsandoval81
Copy link
Collaborator Author

jsandoval81 commented Feb 26, 2025

@jlkravitz That will be true, but only in cases where the user explicitly clears their cache while on the detail page.

Previously that edge case would land them back at a list view with only 1 row (the 1 record they had in their cache from the detail page). That was a lot more of an ambiguous state. In that edge case, this PR now just does what the list view does if the user refreshes, which is send them back to the search page. This felt more consistent, and also gives us a more stable point to progressively enhance the caching in the future (if ever needed).

Copy link
Collaborator

@jlkravitz jlkravitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isabeleliassen This is good to merge after #596 is merged.

@isabeleliassen isabeleliassen merged commit 0e58faf into csg-org:development Feb 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

License list page advance after detail view
4 participants