Feat/display license type #562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsandoval81
suggested changes
Feb 19, 2025
There was a problem hiding this comment.
Nice job. Just an FYI that we're going to have some merge conflicts between this and ticket #521 - they both touch that same area of the PrivilegeCard.
added 2 commits
February 20, 2025 09:56
jsandoval81
approved these changes
Feb 20, 2025
|
@jlkravitz This is ready for your review. |
jlkravitz
reviewed
Feb 21, 2025
jlkravitz
approved these changes
Feb 21, 2025
isabeleliassen
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements List
Description List
LicenseCardandPrivilegeCardcomponents to have license number and privilegeId, added icon when desired and added occupation abbreviationLicenseIconcomponent and use that rather than svg assetLicensemodelTesting List
yarn test:unit:allshould run without errors or warningsyarn serveshould run without errors or warningsyarn buildshould run without errors or warningsLicenseeDashboardandLicenseeDetailpage and confirm that LicenseCard and PrivilegeCard match designsCloses #437