-
Notifications
You must be signed in to change notification settings - Fork 5
Feat/support licensee transaction fees #525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/support licensee transaction fees #525
Conversation
3e8320c
to
6323e7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Only one very minor nit, that I won't hold this up for:
backend/compact-connect/lambdas/python/purchases/tests/unit/test_purchase_client.py
Show resolved
Hide resolved
@jlkravitz, this is ready for you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit but otherwise looks great!
backend/compact-connect/lambdas/python/purchases/tests/unit/test_purchase_client.py
Outdated
Show resolved
Hide resolved
8a5d247
to
5bc3ff3
Compare
We have determined to hold off on this feature until we understand more about the MSPs that the compacts will be using.
5bc3ff3
to
7ef0499
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@isabeleliassen Good to merge when tests pass.
Several compacts have determined to charge credit card transaction fees to licensees, in order to absorb the costs of the fees charged by their Merchant Service Providers. This adds the needed compact configuration fields which compacts will need to specify when they onboard into the compact connect system.
Requirements List
Description List
transactionFeeConfiguration
field to the compact configuration schema, which includes config for licensee transaction fees.Testing List
backend/compact-connect/tests/unit/test_api.py
Closes #502