Skip to content

Feat/support licensee transaction fees #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

landonshumway-ia
Copy link
Collaborator

Several compacts have determined to charge credit card transaction fees to licensees, in order to absorb the costs of the fees charged by their Merchant Service Providers. This adds the needed compact configuration fields which compacts will need to specify when they onboard into the compact connect system.

Requirements List

  • This change is backwards compatible, as these are optional fields that a compact may or may not choose to specify.

Description List

  • Added a transactionFeeConfiguration field to the compact configuration schema, which includes config for licensee transaction fees.
  • Returning these values in the API when the frontend gets the list of compact configuration.
  • Updated the privilege purchase flow to include these transaction fee charges in a separate line item.

Testing List

  • For API configuration changes: CDK tests added/updated in backend/compact-connect/tests/unit/test_api.py
  • uint tests to verify licensee transaction fees are added
  • Code review

Closes #502

@landonshumway-ia landonshumway-ia force-pushed the feat/transaction-fee-config branch from 3e8320c to 6323e7a Compare February 6, 2025 18:03
@landonshumway-ia landonshumway-ia marked this pull request as ready for review February 6, 2025 22:00
Copy link
Collaborator

@jusdino jusdino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Only one very minor nit, that I won't hold this up for:

@jusdino
Copy link
Collaborator

jusdino commented Feb 10, 2025

@jlkravitz, this is ready for you!

Copy link
Collaborator

@jlkravitz jlkravitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit but otherwise looks great!

jlkravitz
jlkravitz previously approved these changes Feb 13, 2025
Copy link
Collaborator

@jlkravitz jlkravitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isabeleliassen Good to merge when tests pass.

@isabeleliassen isabeleliassen self-requested a review February 13, 2025 15:56
@isabeleliassen isabeleliassen merged commit a50addb into csg-org:development Feb 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support passing transaction fees to practitioner when purchasing privileges
4 participants