Feat/privilege numbers #510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
landonshumway-ia
suggested changes
Jan 31, 2025
There was a problem hiding this comment.
Looks really good, just one small thing I noticed in the test data setup and one question.
Also, this is a breaking change right? We will want to note that in the PR description so @jlkravitz is aware
backend/compact-connect/lambdas/python/common/cc_common/data_model/data_client.py
Outdated
Show resolved
Hide resolved
backend/compact-connect/lambdas/python/common/tests/__init__.py
Outdated
Show resolved
Hide resolved
backend/compact-connect/lambdas/python/common/cc_common/data_model/data_client.py
Outdated
Show resolved
Hide resolved
landonshumway-ia
approved these changes
Feb 5, 2025
|
@jlkravitz This one is ready for your review. Thanks |
jlkravitz
reviewed
Feb 5, 2025
backend/compact-connect/lambdas/python/common/cc_common/data_model/data_client.py
Show resolved
Hide resolved
jlkravitz
approved these changes
Feb 5, 2025
isabeleliassen
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description List
Breaking change
With this PR, privileges will all be expected to include
privilegeIdin their schema, so any existing privileges (I think there are a total of 0 in CSG environments) will need updating to include one or just be deleted.Testing List
Closes #466
Closes #436