Skip to content

Feat/scope of practice #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ChiefStief
Copy link
Collaborator

@ChiefStief ChiefStief commented Jan 24, 2025

Requirements List

Description List

  • Added Scope of practice attestation check box to select purchase flow
  • Sourced attestation text and jurisprudence text from server
  • copied attestation model and store logic from: frontend/attestations page #478 with enhancement in model and tests for line breaks
  • Enhanced focus trap logic based on recent sprint pr feedback for accessibility

Testing List

  • yarn test:unit:all should run without errors or warnings
  • yarn serve should run without errors or warnings
  • yarn build should run without errors or warnings
  • Code review
  • Go through the present privilege purchase process up to the credit card page and confirm that the scope of practice attestation looks good as do all the attestations. Also, confirm that all expected attestations are added to the store at this point

Closes #283

@ChiefStief ChiefStief marked this pull request as ready for review January 27, 2025 21:33
@jsandoval81
Copy link
Collaborator

@ChiefStief This is initially approved 👍 . If you want, I can re-review after the merge of #478 and your updates from the PR Requirements List.

@ChiefStief ChiefStief requested a review from jlkravitz January 31, 2025 21:49
@ChiefStief
Copy link
Collaborator Author

@jlkravitz This is ready for your review

Copy link
Collaborator

@jlkravitz jlkravitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to submit the review last week...woops, sorry about that. One nit!

@ChiefStief ChiefStief requested a review from jlkravitz February 3, 2025 18:41
Copy link
Collaborator

@jlkravitz jlkravitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isabeleliassen Good to merge!

@isabeleliassen isabeleliassen self-requested a review February 3, 2025 23:07
@isabeleliassen isabeleliassen merged commit f5d5eb0 into csg-org:development Feb 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scope of practice attestation
4 participants