Skip to content

Support Windows system time zone transitions in all years #15891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

HertzDevil
Copy link
Contributor

Adds a new Time::WindowsLocation class that handles month + week + day-of-week transitions both before the first fixed transition and after the last fixed transition. This eliminates the need to arbitrarily store 201 years' worth of fixed transitions in any Windows system time zone.

The side effect is that there are indeed no fixed transitions now, these will have to wait until #13518.

@HertzDevil HertzDevil moved this to Review in Windows Support Jun 10, 2025
@HertzDevil HertzDevil added the platform:windows Windows support based on the MSVC toolchain / Win32 API label Jun 10, 2025
@straight-shoota straight-shoota added this to the 1.17.0 milestone Jun 11, 2025
@straight-shoota straight-shoota merged commit 21114e4 into crystal-lang:master Jun 13, 2025
37 checks passed
@github-project-automation github-project-automation bot moved this from Review to Done in Windows Support Jun 13, 2025
@HertzDevil HertzDevil deleted the feature/windows-time-zone-transitions branch June 13, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feature platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib:time
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants