Skip to content

Add trailing newlines #15870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2025
Merged

Add trailing newlines #15870

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71a6e85
Fix Lint/TrailingBlankLines
straight-shoota Jun 3, 2025
db15e2b
Add `.ecr` to `.editorconfig`
straight-shoota Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
root = true

[*.cr]
[*.{cr,ecr}]
charset = utf-8
end_of_line = lf
insert_final_newline = true
Expand Down
2 changes: 1 addition & 1 deletion spec/std/data/test_template3.ecr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<%- 2.times do |i| %><%= i %><% end -%>
<%- 2.times do |i| %><%= i %><% end -%>
2 changes: 1 addition & 1 deletion spec/std/data/test_template4.ecr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
hi
<%- 2.times do |i| %><%= i %><% end -%>
<%- 2.times do |i| %><%= i %><% end -%>
2 changes: 1 addition & 1 deletion spec/std/data/test_template6.ecr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<%= "string with -%" %>
<%= "string with -%" %>
2 changes: 1 addition & 1 deletion spec/std/data/test_template7.ecr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
Greetings, <%%= @name %>!
<%-% else -%>
Greetings!
<%-% end -%>
<%-% end -%>
3 changes: 2 additions & 1 deletion spec/std/ecr/ecr_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ describe "ECR" do
it "does with -% inside string" do
io = IO::Memory.new
ECR.embed "#{__DIR__}/../data/test_template6.ecr", io
io.to_s.should eq("string with -%")
io.to_s.should eq("string with -%\n")
end

it "does with <%% %>" do
Expand All @@ -74,6 +74,7 @@ describe "ECR" do
<%- else -%>
Greetings!
<%- end -%>

ECR
end

Expand Down