Skip to content

Add fallback if __crystal_raise_cast_failed is missing #15762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

HertzDevil
Copy link
Contributor

This is pretty much the implementation before #15708, so that a new compiler can use an older standard library where __crystal_raise_cast_failed is not defined.

@straight-shoota straight-shoota added this to the 1.16.3 milestone May 10, 2025
@straight-shoota straight-shoota added the kind:bug A bug in the code. Does not apply to documentation, specs, etc. label May 10, 2025
@straight-shoota straight-shoota merged commit 1887c81 into crystal-lang:master May 12, 2025
10 checks passed
@crysbot
Copy link
Collaborator

crysbot commented May 12, 2025

Successfully created backport PR for release/1.16:

@crysbot
Copy link
Collaborator

crysbot commented May 12, 2025

Git push to origin failed for release/1.16 with exitcode 1

@HertzDevil HertzDevil deleted the bug/raise-cast-failed-missing branch May 12, 2025 14:23
straight-shoota pushed a commit that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release/1.16 kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:codegen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants