Fix run win32 console reader in bare thread #15724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
added
kind:bug
straight-shoota
approved these changes
Apr 28, 2025
Server Errorcreated backport PR for |
straight-shoota
pushed a commit
that referenced
this pull request
Apr 28, 2025
Co-authored-by: Julien Portalier <[email protected]>
ysbaddaden
deleted the
fix/start-win32-console-reader-loop-in-bare-thread
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simpler alternative to #15714 that focuses on dropping the isolated context that depends on the default context (not yet initialized at this point) and we don't need the isolated context bubble wrap anyway.
Closes #15714