Fix: CRYSTAL_LOAD_DEBUG_INFO=1 fails with -Dexecution_context
#15704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysbaddaden
added
the
kind:bug
straight-shoota
approved these changes
Apr 24, 2025
|
On Windows apparently this is not early enough: |
|
I presume we should still merge this, though? |
This comment was marked as outdated.
This comment was marked as outdated.
|
I'll propose a few changes for Windows in a separate branch (no need for the isolated context + we should control when to start the thread). EDIT: I eventually reproduced 🤦 I'll still push a fix as explained above |
|
Successfully created backport PR for |
straight-shoota
pushed a commit
that referenced
this pull request
Apr 28, 2025
#15715) Co-authored-by: Julien Portalier <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading the debug info relies on
Fileand goes through the event loop (even if reading files is blocking) which in turn requires a fiber scheduler (event loops are tied to a scheduler).They used to be lazily instantiated, but with execution contexts it must be explicit. We thus have to load the debug info after creating the default execution context.