Skip to content

Fix async append to file in IOCP #15681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ysbaddaden
Copy link
Contributor

closes #15680

@ysbaddaden ysbaddaden added kind:bug A bug in the code. Does not apply to documentation, specs, etc. platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib:files labels Apr 17, 2025
@ysbaddaden ysbaddaden requested a review from HertzDevil April 17, 2025 17:51
@ysbaddaden ysbaddaden self-assigned this Apr 17, 2025
@straight-shoota straight-shoota added this to the 1.17.0 milestone Apr 18, 2025
ysbaddaden added a commit to ysbaddaden/crystal that referenced this pull request Apr 18, 2025
@straight-shoota straight-shoota changed the title Fix: windows cant append to file async Fix async append to file in IOCP Apr 22, 2025
@straight-shoota straight-shoota merged commit a6e1e9b into crystal-lang:master Apr 22, 2025
34 checks passed
@ysbaddaden ysbaddaden deleted the fix/windows-cant-append-to-file-async branch April 28, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. platform:windows Windows support based on the MSVC toolchain / Win32 API topic:stdlib:files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't append to file on windows without blocking
2 participants