Skip to content

[CI] Add build shards to mingw-w64 workflow #15344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 17, 2025
Merged

[CI] Add build shards to mingw-w64 workflow #15344

merged 3 commits into from
Jan 17, 2025

Conversation

straight-shoota
Copy link
Member

No description provided.

@straight-shoota straight-shoota self-assigned this Jan 14, 2025
@ysbaddaden
Copy link
Contributor

ysbaddaden commented Jan 15, 2025 •
edited
Loading

A couple errors on CI:

Missing libyaml:

mingw32/bin/ld.exe: cannot find -lyaml (this usually means you need to install the development package for libyaml): No such file or directory

Missing tag version for downloading the molinillo dep:

curl -L "https://github.com/crystal-lang/crystal-molinillo/archive/v.tar.gz"

☝️ maybe we should vendor the dependency, just like we vendor them for crystal?

@straight-shoota
Copy link
Member Author

Now the build was successful 🚀

@straight-shoota straight-shoota added this to the 1.15.1 milestone Jan 15, 2025
@straight-shoota straight-shoota mentioned this pull request Jan 15, 2025
Merged
@ysbaddaden
Copy link
Contributor

Yeah, apparently all it was missing was libyaml 🤷

ysbaddaden
ysbaddaden approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@ysbaddaden ysbaddaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@straight-shoota straight-shoota merged commit cfd8ea1 into crystal-lang:release/1.15 Jan 17, 2025
3 of 66 checks passed
@straight-shoota straight-shoota deleted the release/1.15 branch January 17, 2025 12:19
@BrewTestBot BrewTestBot mentioned this pull request Feb 4, 2025
Merged
1 task
@HertzDevil
Copy link
Contributor

This is simply running make twice at the Crystal repository root because no working directory is supplied here, so the build artifacts still have neither shards.exe nor libyaml-0-2.dll

@straight-shoota straight-shoota mentioned this pull request Feb 11, 2025
Closed
@straight-shoota
Copy link
Member Author

Oh I had already fixed this, but apparently never submitted the PR 🤦 Here it is: #15451

The release tarball for 1.15.1 was created from the branch with the fix, so that does work.

straight-shoota added a commit to crystal-lang/shards that referenced this pull request Feb 22, 2025
@straight-shoota
Vendor lib/molinillo (#663)
02ff388 
Commits the dependency code into this repository, as suggested in crystal-lang/crystal#15344 (comment). We're already doing the same in https://github.com/crystal-lang/crystal.

This simplifies the build process. All code required for building shards is contained in this repository (except for Crystal stdlib). There's no need to bootstrap the initial installation of the molinillo dependency anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysbaddaden ysbaddaden ysbaddaden approved these changes

Assignees

@straight-shoota straight-shoota

Labels
topic:infrastructure/ci
Projects
None yet
Milestone
1.15.1
Development

Successfully merging this pull request may close these issues.
3 participants
@straight-shoota @ysbaddaden @HertzDevil