Use be_nil and be_true/be_false everywhere in specs (#15867)

Transforms all `eq nil` and `eq true`/`eq false` calls in specs to `be_nil` and `be_true`/`be_false` to enforce a consistent style.
We're already using `be_*` in the vast majority of cases. Less than 10% of expectations are using the `eq` style.

Author: straight-shoota

spec/compiler/codegen/const_spec.cr

@@ -566,6 +566,6 @@ describe "Codegen: const" do
 
       CONST = foo
       CONST.nil?
-      )).to_b.should eq(true)
+      )).to_b.should be_true
   end
 end

spec/compiler/codegen/macro_spec.cr

@@ -596,7 +596,7 @@ describe "Code gen: macro" do
         end
       end
       Foo(1).new.foo
-    )).to_b.should eq(true)
+    )).to_b.should be_true
   end
 
   it "can access type variables of a tuple" do
@@ -1867,7 +1867,7 @@ describe "Code gen: macro" do
       end
 
       Foo.new.bar
-      )).to_b.should eq(true)
+      )).to_b.should be_true
   end
 
   it "does block unpacking inside macro expression (#13707)" do

spec/compiler/codegen/regex_literal_spec.cr

@@ -12,6 +12,6 @@ describe "Code gen: regex literal spec" do
         end
       end
       Foo.check_regex
-      )).to_b.should eq(true)
+      )).to_b.should be_true
   end
 end

spec/compiler/crystal/tools/doc/type_spec.cr

@@ -140,7 +140,7 @@ describe Doc::Type do
     generator = Doc::Generator.new program, [""]
     macros_module = program.types["Crystal"].types["Macros"]
     astnode = generator.type(macros_module.types["ASTNode"])
-    astnode.superclass.should eq(nil)
+    astnode.superclass.should be_nil
     # Sanity check: subclasses of ASTNode has the right superclass
     generator.type(macros_module.types["Arg"]).superclass.should eq(astnode)
   end

spec/compiler/crystal/tools/repl_spec.cr

@@ -14,7 +14,7 @@ describe Crystal::Repl do
     repl.load_prelude
 
     success_value(repl.parse_and_interpret("1 + 2")).value.should eq(3)
-    success_value(repl.parse_and_interpret("def foo; 1 + 2; end")).value.should eq(nil)
+    success_value(repl.parse_and_interpret("def foo; 1 + 2; end")).value.should be_nil
     success_value(repl.parse_and_interpret("foo")).value.should eq(3)
   end
 

spec/compiler/interpreter/bugs_spec.cr

@@ -136,7 +136,7 @@ describe Crystal::Repl::Interpreter do
     end
 
     it "does multidispatch on virtual struct" do
-      interpret(<<-CRYSTAL).should eq(true)
+      interpret(<<-CRYSTAL).should be_true
         abstract struct Base
         end
 
@@ -187,7 +187,7 @@ describe Crystal::Repl::Interpreter do
     end
 
     it "does multidispatch on virtual struct union nil" do
-      interpret(<<-CRYSTAL).should eq(true)
+      interpret(<<-CRYSTAL).should be_true
         abstract struct Foo
           @value = 1
         end

spec/compiler/interpreter/casts_spec.cr

@@ -25,7 +25,7 @@ describe Crystal::Repl::Interpreter do
     end
 
     it "casts from mixed union type to another mixed union type for caller" do
-      interpret(<<-CRYSTAL).should eq(true)
+      interpret(<<-CRYSTAL).should be_true
         a = 1 == 1 ? 1 : (1 == 1 ? 20_i16 : nil)
         if a
           a < 2
@@ -49,7 +49,7 @@ describe Crystal::Repl::Interpreter do
     end
 
     it "casts from nilable type to mixed union type (2)" do
-      interpret(<<-CRYSTAL).should eq(true)
+      interpret(<<-CRYSTAL).should be_true
         y = 1 == 1 ? "a" : nil
         x = true
         x = y

spec/compiler/interpreter/constants_spec.cr

@@ -4,7 +4,7 @@ require "./spec_helper"
 describe Crystal::Repl::Interpreter do
   context "constants" do
     it "returns nil in the assignment" do
-      interpret(<<-CRYSTAL).should eq(nil)
+      interpret(<<-CRYSTAL).should be_nil
         A = 123
       CRYSTAL
     end

spec/compiler/interpreter/control_flow_spec.cr

@@ -70,7 +70,7 @@ describe Crystal::Repl::Interpreter do
     end
 
     it "interprets while, returns nil" do
-      interpret(<<-CRYSTAL).should eq(nil)
+      interpret(<<-CRYSTAL).should be_nil
         a = 0
         while a < 10
           a = a + 1

spec/compiler/interpreter/primitives_spec.cr

@@ -95,7 +95,7 @@ describe Crystal::Repl::Interpreter do
     end
 
     it "uses a string pool" do
-      interpret(<<-CRYSTAL).should eq(true)
+      interpret(<<-CRYSTAL).should be_true
         "a".object_id == "a".object_id
       CRYSTAL
     end
@@ -153,7 +153,7 @@ describe Crystal::Repl::Interpreter do
     end
 
     it "doesn't declare variable with no type" do
-      interpret(<<-CRYSTAL).should eq(nil)
+      interpret(<<-CRYSTAL).should be_nil
       x = nil
       if x
         y = x
@@ -162,7 +162,7 @@ describe Crystal::Repl::Interpreter do
     end
 
     it "doesn't declare variable with no type inside method" do
-      interpret(<<-CRYSTAL).should eq(nil)
+      interpret(<<-CRYSTAL).should be_nil
         def foo(x)
           if x
             y = x
@@ -702,19 +702,19 @@ describe Crystal::Repl::Interpreter do
 
   context "logical operations" do
     it "interprets not for nil" do
-      interpret("!nil").should eq(true)
+      interpret("!nil").should be_true
     end
 
     it "interprets not for nil type" do
       interpret("x = 1; !(x = 2; nil); x").should eq(2)
     end
 
     it "interprets not for bool true" do
-      interpret("!true").should eq(false)
+      interpret("!true").should be_false
     end
 
     it "interprets not for bool false" do
-      interpret("!false").should eq(true)
+      interpret("!false").should be_true
     end
 
     it "discards nil not" do
@@ -726,35 +726,35 @@ describe Crystal::Repl::Interpreter do
     end
 
     it "interprets not for bool false" do
-      interpret("!false").should eq(true)
+      interpret("!false").should be_true
     end
 
     it "interprets not for mixed union (nil)" do
-      interpret("!(1 == 1 ? nil : 2)").should eq(true)
+      interpret("!(1 == 1 ? nil : 2)").should be_true
     end
 
     it "interprets not for mixed union (false)" do
-      interpret("!(1 == 1 ? false : 2)").should eq(true)
+      interpret("!(1 == 1 ? false : 2)").should be_true
     end
 
     it "interprets not for mixed union (true)" do
-      interpret("!(1 == 1 ? true : 2)").should eq(false)
+      interpret("!(1 == 1 ? true : 2)").should be_false
     end
 
     it "interprets not for mixed union (other)" do
-      interpret("!(1 == 1 ? 2 : true)").should eq(false)
+      interpret("!(1 == 1 ? 2 : true)").should be_false
     end
 
     it "interprets not for nilable type (false)" do
-      interpret(%(!(1 == 1 ? "hello" : nil))).should eq(false)
+      interpret(%(!(1 == 1 ? "hello" : nil))).should be_false
     end
 
     it "interprets not for nilable type (true)" do
-      interpret(%(!(1 == 1 ? nil : "hello"))).should eq(true)
+      interpret(%(!(1 == 1 ? nil : "hello"))).should be_true
     end
 
     it "interprets not for nilable proc type (true)" do
-      interpret(<<-CRYSTAL).should eq(true)
+      interpret(<<-CRYSTAL).should be_true
         a =
           if 1 == 1
             nil
@@ -766,7 +766,7 @@ describe Crystal::Repl::Interpreter do
     end
 
     it "interprets not for nilable proc type (false)" do
-      interpret(<<-CRYSTAL).should eq(false)
+      interpret(<<-CRYSTAL).should be_false
         a =
           if 1 == 1
             ->{ 1 }
@@ -778,7 +778,7 @@ describe Crystal::Repl::Interpreter do
     end
 
     it "interprets not for generic class instance type" do
-      interpret(<<-CRYSTAL).should eq(false)
+      interpret(<<-CRYSTAL).should be_false
         class Foo(T)
         end
 
@@ -788,7 +788,7 @@ describe Crystal::Repl::Interpreter do
     end
 
     it "interprets not for nilable type (false)" do
-      interpret(<<-CRYSTAL).should eq(false)
+      interpret(<<-CRYSTAL).should be_false
         class Foo
         end
 
@@ -805,7 +805,7 @@ describe Crystal::Repl::Interpreter do
     end
 
     it "interprets not for nilable type (true)" do
-      interpret(<<-CRYSTAL).should eq(true)
+      interpret(<<-CRYSTAL).should be_true
         class Foo
         end
 
@@ -822,7 +822,7 @@ describe Crystal::Repl::Interpreter do
     end
 
     it "interprets not for module (#12918)" do
-      interpret(<<-CRYSTAL).should eq(false)
+      interpret(<<-CRYSTAL).should be_false
         module MyModule; end
 
         class One
@@ -834,7 +834,7 @@ describe Crystal::Repl::Interpreter do
     end
 
     it "interprets not for generic module" do
-      interpret(<<-CRYSTAL).should eq(false)
+      interpret(<<-CRYSTAL).should be_false
         module MyModule(T); end
 
         class One
@@ -846,15 +846,15 @@ describe Crystal::Repl::Interpreter do
     end
 
     it "interprets not for generic module metaclass" do
-      interpret(<<-CRYSTAL).should eq(false)
+      interpret(<<-CRYSTAL).should be_false
         module MyModule(T); end
 
         !MyModule(Int32)
         CRYSTAL
     end
 
     it "interprets not for generic class instance metaclass" do
-      interpret(<<-CRYSTAL).should eq(false)
+      interpret(<<-CRYSTAL).should be_false
         class MyClass(T); end
 
         !MyClass(Int32)

spec/compiler/interpreter/types_spec.cr

@@ -107,7 +107,7 @@ describe Crystal::Repl::Interpreter do
     end
 
     it "interprets crystal_type_id for virtual metaclass type (#12228)" do
-      interpret(<<-CRYSTAL).should eq(true)
+      interpret(<<-CRYSTAL).should be_true
         class P
         end
 

spec/compiler/interpreter/unions_spec.cr

@@ -11,7 +11,7 @@ describe Crystal::Repl::Interpreter do
     end
 
     it "put and remove from union, together with is_a? (falsey case)" do
-      interpret(<<-CRYSTAL).should eq(true)
+      interpret(<<-CRYSTAL).should be_true
         a = 1 == 2 ? 2 : true
         a.is_a?(Int32) ? true : a
         CRYSTAL