Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error to the RescuedExceptionsVariableName#allowed_names #438

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Add error to the RescuedExceptionsVariableName#allowed_names #438

merged 1 commit into from
Dec 28, 2023

Conversation

Sija
Copy link
Member

@Sija Sija commented Dec 28, 2023 •
edited
Loading

Supersedes #437
Resolves #433

@Sija Sija added this to the 1.6.1 milestone Dec 28, 2023
@Sija Sija requested a review from veelenga December 28, 2023 12:07
@Sija Sija self-assigned this Dec 28, 2023
@Sija Sija mentioned this pull request Dec 28, 2023
Closed
@Sija Sija enabled auto-merge December 28, 2023 12:09
veelenga
veelenga approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sija Sija merged commit 46a42ee into master Dec 28, 2023
@Sija Sija deleted the add-error-as-allowed-variable-name branch December 28, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veelenga veelenga veelenga approved these changes

Assignees

@Sija Sija

Labels
refactor rule
Projects
None yet
Milestone
1.6.1
Development

Successfully merging this pull request may close these issues.

exception names are too limited
2 participants
@Sija @veelenga