Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lint): useless assignment for type definition #351

Merged
merged 6 commits into from
Feb 19, 2023
Merged

fix(lint): useless assignment for type definition #351

merged 6 commits into from
Feb 19, 2023

Conversation

veelenga
Copy link
Member

@veelenga veelenga commented Feb 4, 2023

closes #342

@veelenga veelenga requested a review from Sija February 4, 2023 14:58
@veelenga veelenga self-assigned this Feb 4, 2023
@veelenga veelenga marked this pull request as draft February 4, 2023 15:03
@veelenga veelenga removed the request for review from Sija February 4, 2023 15:04
@veelenga veelenga force-pushed the fix/useless-assign-type-def branch from e932ded to 14a9ec3 Compare February 4, 2023 18:53
@Sija
Copy link
Member

Sija commented Feb 7, 2023

@veelenga Is this GTG?

@Sija Sija added the bug label Feb 7, 2023
Sija
Sija reviewed Feb 7, 2023
View reviewed changes
@veelenga
Copy link
Member Author

veelenga commented Feb 7, 2023 •
edited
Loading

Not yet done. Still need to add a bit more tests. Thanks for the feedback.

@veelenga veelenga marked this pull request as ready for review February 7, 2023 15:19
Sija
Sija reviewed Feb 7, 2023
View reviewed changes
@veelenga veelenga force-pushed the fix/useless-assign-type-def branch from 5fdc47c to d20cc21 Compare February 7, 2023 18:03
@veelenga veelenga requested a review from Sija February 7, 2023 20:21
Sija
Sija approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@Sija Sija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG from my side, yet wait please with the merge until we figure out what to do with current 1.4.0 release.

@Sija Sija mentioned this pull request Feb 18, 2023
Closed
@veelenga veelenga merged commit 8f5d2cc into master Feb 19, 2023
@veelenga veelenga deleted the fix/useless-assign-type-def branch February 19, 2023 06:50
@Sija Sija added this to the 1.4.1 milestone Feb 19, 2023
@Sija Sija added the rule label Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sija Sija Sija approved these changes

Assignees

@veelenga veelenga

Labels
bug rule
Projects
None yet
Milestone
1.4.1
Development

Successfully merging this pull request may close these issues.

Unexpected [Lint/UselessAssign] Useless assignment to variable
2 participants
@veelenga @Sija