Add Lint/UnusedBlockArgument rule
#320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
force-pushed
the
Sija/unused-block-argument
branch
from
87e1fec to
2cc3ae0
Compare
veelenga
reviewed
Dec 15, 2022
| def method(a, b, c, &) | ||
| end | ||
| ) | ||
| subject.catch(s).should be_valid |
There was a problem hiding this comment.
shouldn't we use that newer matcher expect_no_issues/expect_issue instead?
There was a problem hiding this comment.
yeah, we should but I was too lazy to rewrite those, xmas & all that jazz, sorry!
There was a problem hiding this comment.
There are still many specs to rewrite anyway...
veelenga
reviewed
Dec 15, 2022
Sija
force-pushed
the
Sija/unused-block-argument
branch
from
08cb812 to
bb0c0ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #158