Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a typo in README #23

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Fix a typo in README #23

merged 1 commit into from
Jan 16, 2020

Conversation

max0ne
Copy link
Contributor

@max0ne max0ne commented Jan 16, 2020

No description provided.

@max0ne
Fix a typo in README
0b938b3 
Signed-off-by: Mingfei Huang <[email protected]>
mllu
mllu approved these changes Jan 16, 2020
View reviewed changes
Copy link

@mllu mllu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but not sure if I have power to approve

@mllu
Copy link

mllu commented Jan 16, 2020

I do!

just realized this repo requires a signed commit https://github.com/cruise-automation/rbacsync#contributions, are you able to do that and force push again?

@max0ne
Copy link
Contributor Author

max0ne commented Jan 16, 2020

I do!

just realized this repo requires a signed commit https://github.com/cruise-automation/rbacsync#contributions, are you able to do that and force push again?

Done! It is signed, just have to add the public key to this Github account.

@mllu mllu merged commit e822ad8 into cruise-automation:master Jan 16, 2020
@mllu
Copy link

mllu commented Jan 16, 2020

thanks for the typo fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mllu mllu mllu approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@max0ne @mllu