This repository was archived by the owner on Jan 30, 2025. It is now read-only.
Tiling interface for slice op #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navahgar
force-pushed
the
slice_tiling_interface
branch
from
418630d to
2d70c9a
Compare
srinathava
reviewed
Jun 26, 2024
srinathava
reviewed
Jun 27, 2024
navahgar
force-pushed
the
slice_tiling_interface
branch
from
2031e91 to
41f7f0b
Compare
srinathava
approved these changes
Jun 27, 2024
|
|
||
| namespace { | ||
|
|
||
| Value getOpFoldResultAsValue(OpFoldResult ofr, OpBuilder &b, |
There was a problem hiding this comment.
This and its sibling below already exist upstream. See here:
There was a problem hiding this comment.
Thanks for pointing that out. I found some utils related to OpFoldResult in https://sourcegraph.com/github.com/llvm/llvm-project@main/-/blob/mlir/include/mlir/Dialect/Utils/StaticValueUtils.h, but didn't realize there are more of these under arith. Wonder why they are separate.
navahgar
force-pushed
the
slice_tiling_interface
branch
from
41f7f0b to
20ff6d1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an implementation of
TilingInterfacefor thetcp.sliceop. This is necessary to enable tile and fuse withtcp.slice.