Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowlists: fix range check in LAPI endpoint #3538

Merged
merged 4 commits into from
Mar 25, 2025
Merged

Conversation

blotus
Copy link
Member

@blotus blotus commented Mar 25, 2025

Properly escape the value to check for allowlisting when querying the LAPI endpoint.
The bug only impacted cscli, LAPI and the appsec do not use this endpoint to check if a value is allowlisted or not.

Copy link

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@blotus
Copy link
Member Author

blotus commented Mar 25, 2025

/kind fix
/area local-api

Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.38%. Comparing base (55aa189) to head (f53af23).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/apiclient/allowlists_service.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3538      +/-   ##
==========================================
+ Coverage   57.27%   57.38%   +0.10%     
==========================================
  Files         391      391              
  Lines       43820    43824       +4     
==========================================
+ Hits        25100    25150      +50     
+ Misses      16601    16550      -51     
- Partials     2119     2124       +5     
Flag Coverage Δ
bats 42.77% <66.66%> (+0.13%) ⬆️
unit-linux 33.57% <33.33%> (+<0.01%) ⬆️
unit-windows 22.62% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@blotus blotus merged commit d64f196 into master Mar 25, 2025
15 checks passed
@blotus blotus deleted the allowlists-check-range branch March 25, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants