[Blink] WebCL: Remove config.h and ENABLE_WEBCL. #316
Conversation
|
@Bysmyyr, I've fixed the compile problem. Build without -Denable_webcl=1 on linux won't cause any compile error. And WebCL will be enabled only by -Denable_webcl=1 on linux. Pls have a try. |
shaoboyan
force-pushed
the
XWALK-6200
branch
from
2fc2e1b to
8425331
Compare
|
Morning, testing now, thanks. ps. you do not need new pr, just force push to that previous |
|
hi, I found build errror:
|
|
that repush did not change anything? |
|
@Bysmyyr No, it changes, since last time it is a compile error which lacks of files . But this time, as you can see, this is a warning error, you can use -DWerror= . However when build webcl on android platfrom with gcc thiis error wouldn't occur. However, I'll fix this warning if you wish |
|
Well, the compiler warning/error does point to an actual mistake that should be fixed. |
shaoboyan
force-pushed
the
XWALK-6200
branch
from
8425331 to
22f20c5
Compare
shaoboyan
force-pushed
the
XWALK-6200
branch
2 times, most recently
from
4080d41 to
45502b8
Compare
|
WebCLCommandQueue.cpp calls |
|
@hujiajie done. |
shaoboyan
force-pushed
the
XWALK-6200
branch
2 times, most recently
from
0373db5 to
20328b9
Compare
|
ok, thanks, lets try |
|
@shaoboyan now it builds fine. I will merge after you fix that whitespace |
shaoboyan
force-pushed
the
XWALK-6200
branch
from
20328b9 to
4412441
Compare
|
@Bysmyyr thx. |
[Blink] WebCL: Remove config.h and ENABLE_WEBCL.
|
All C++ changes LGTM, but changes in gyp does not seem to be perfect yet, especially due to the use of modules_idl_files_list.tmp and multiple |
|
make a new pullrequest which reverts those and adds them again fixed when you have something better but use these for now... I will drop those reverts then. Thanks for everybody for efforts this far |
Compile Error Since upstream removed config.h file from Blink Source dir, WebCL need to replace "config.h" with "wtf/build_config.h". This patch also fix some compile error caused by upstream API changes. BUG=XWALK-6200
Since upstream delete idl extension attribute 'Conditional', WebCL related idls which depend on it need to be updated. Now using gyp to control whether enable WebCL and discard ENABLE_WEBCL macro. BUG=XWALK-6200
Removed shownComponentsChanged_() in favor of updateElementPositioning_(). Moved async() method to ensure any microtasks such as first run flow or issue stamping has concluded before the positioning of the WebUI elements is determined. BUG=583203 Review URL: https://codereview.chromium.org/1652203004 Cr-Commit-Position: refs/heads/master@{#373116} (cherry picked from commit 75b93c4) Review URL: https://codereview.chromium.org/1683503002 . Cr-Commit-Position: refs/branch-heads/2623@{#316} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
…og for Mac. This change uses an autoresizing dialog for Media Router on Macs rather than a fixed size dialog. Previously, the dialog could only autoresize on Linux and Windows. The original CL was reverted because it depended on a patch that was reverted. It can be found here: https://codereview.chromium.org/1680533003/ BUG=508544, 580272, 580273 Review URL: https://codereview.chromium.org/1779253003 Cr-Commit-Position: refs/heads/master@{#381128} (cherry picked from commit d903c98) Review URL: https://codereview.chromium.org/1820983002 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#316} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
URL change without document change may create a new entry in NavigationManager, hence SSL status should be updated for it. BUG=562024 Review URL: https://codereview.chromium.org/1508253002 Cr-Commit-Position: refs/heads/master@{#363856} (cherry picked from commit 2b6af83) Review URL: https://codereview.chromium.org/1517083002 . Cr-Commit-Position: refs/branch-heads/2564@{crosswalk-project#316} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
Added back the missing plumbing. Also added EventSender support to pass stylus info for testing. BUG=593850 Review-Url: https://codereview.chromium.org/2043053002 Cr-Commit-Position: refs/heads/master@{#398933} (cherry picked from commit abca6ff) Review URL: https://codereview.chromium.org/2054123002 . Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#316} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
This reverts commit 267e445. Reason for revert: We've already seen lots of breakages with PlzNavigate Original change's description: > AW: enable PlzNavigate via CLI switch > > This CL enables PlzNavigate (browser side navigation) by default for > WebView only. This is to try out the new code path before launching at > 100% for all of chrome. > > [email protected] > > (cherry picked from commit dbc2bb9) > > Bug: 765250 > Test: Manual > Change-Id: Iff2d0585e11075e71fe196df47503d950e2b26b3 > Reviewed-on: https://chromium-review.googlesource.com/667502 > Reviewed-by: Selim Gurun <[email protected]> > Commit-Queue: Nate Fischer <[email protected]> > Cr-Original-Commit-Position: refs/heads/master@{#502121} > Reviewed-on: https://chromium-review.googlesource.com/671187 > Reviewed-by: Nate Fischer <[email protected]> > Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#300} > Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098} [email protected],[email protected] Change-Id: I173db64902172655a72161a244f3923c9c9ef196 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 765250 Reviewed-on: https://chromium-review.googlesource.com/672156 Reviewed-by: Nate Fischer <[email protected]> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#316} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
This PR resolve XWALK-6200.