This repository was archived by the owner on Apr 3, 2020. It is now read-only.
Add gyp flag use_minimum_resources and exclude unnecessary resources #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing patch series with lincsoon/chromium-crosswalk@f1a020607746aa1e330360d56ed5f95f83ee4322 as its head.
|
| @@ -741,6 +741,7 @@ struct DataResource { | |||
| const DataResource kDataResources[] = { | |||
| {"missingImage", IDR_BROKENIMAGE, ui::SCALE_FACTOR_100P}, | |||
| {"missingImage@2x", IDR_BROKENIMAGE, ui::SCALE_FACTOR_200P}, | |||
| /* | |||
There was a problem hiding this comment.
comment out is not right way if we consider other platforms like Linux. I'd suggest we use define and use USE_MINIMUM_RESOURCES macro.
|
Testing patch series with lincsoon/chromium-crosswalk@cf1ef04cece86740e2fcc4bbeddb016506375928 as its head.
|
Remove following resources: 1. Resources for media player control bar, this part is not usually used, thus it could be overriden by web developers. 2. The ui resources are for aura/views, Android doesn't need it. This patch is the backport from Crosswalk-lite BUG=https://crosswalk-project.org/jira/browse/XWALK-3928 TEST=Build with/without flag use_minimum_resources and simple test on XWalkCoreShell.apk SIZE_REDUCED=212k(Release build on ARM)
|
Testing patch series with lincsoon/chromium-crosswalk@21e79bed51c3026e97f3bf50b75b83206b96c74e as its head.
|
|
LGTM, ping @darktears |
darktears
added a commit
that referenced
this pull request
Jun 8, 2015
Add gyp flag use_minimum_resources and exclude unnecessary resources
rakuco
pushed a commit
that referenced
this pull request
Aug 13, 2015
WebView embedders can suppress fling animation updates, potentially confusing the tap suppression controller. As the feature isn't critical, simply disable it for WebView. Also refactor the input router settings helper to use ui::GestureConfiguration directly for configuring tap suppression. This makes it simpler for different platforms to customize behavior. BUG=514783 Review URL: https://codereview.chromium.org/1267693004 Cr-Commit-Position: refs/heads/master@{#342019} (cherry picked from commit 36fee7b) Review URL: https://codereview.chromium.org/1281553004 . Cr-Commit-Position: refs/branch-heads/2454@{#251} Cr-Branched-From: 12bfc33-refs/heads/master@{#338390}
mrunalk
pushed a commit
that referenced
this pull request
Dec 18, 2015
This test was already partially disabled on iOS (using the |supports_non_dotted_domains| parameter). This CL disables a larger part of the test, to unblock the commit queue. TBR=ellyjones BUG=564543 Review URL: https://codereview.chromium.org/1490393003 Cr-Commit-Position: refs/heads/master@{#362958} (cherry picked from commit a89468d) Review URL: https://codereview.chromium.org/1507513003 . Cr-Commit-Position: refs/branch-heads/2564@{#251} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2016
cherry picked from 1624f7e with a manual adjustment for the 1st chunk. (there's one line difference between the trunk and M49 branch making the cherry-pick fail.) Use safe macros for UTF-8 iteration in sqlite Instead of U8_NEXT_UNSAFE and U8_FWD1_UNSAFE, use U8_NEXT_OR_FFFD (efficient) and U8_FWD1 (slower than UNSAFE version). Original CL: https://codereview.chromium.org/1643803003 BUG=575205 TEST=See comment 32 in the bug [email protected],[email protected] Review URL: https://codereview.chromium.org/1660613003 . Cr-Commit-Position: refs/branch-heads/2623@{#251} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
BUG=592032 Review URL: https://codereview.chromium.org/1784093002 Cr-Commit-Position: refs/heads/master@{#381231} (cherry picked from commit 400ad19) Review URL: https://codereview.chromium.org/1807773002 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#251} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
Callers of ChildSharedBitmapManager::AllocateSharedMemoryBitmap are not prepared to handle failures. The existence of the FastShutdown path means that any message might fail. Either all callers of ChildSharedBitmapManager::AllocateSharedMemoryBitmap need to handle failure, or else the process needs to exit immediately. The latter seems more manageable. BUG=615121 Review-Url: https://codereview.chromium.org/2028833003 Cr-Commit-Position: refs/heads/master@{#397496} (cherry picked from commit 7eb3f7f) Review URL: https://codereview.chromium.org/2045713002 . Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#251} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
GPU raster was already enabled for 1GB devices pre-O. O changes the IsLowEndDevice() function to return true for 1GB, potentially disabling GPU raster. To prevent performance regressions, we now control GPU raster by the devices physical memory, not IsLowEndDevice(). Bug: 763003 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia4f2d399e70f6cd8ef287026fc8459d27e1bbc8d Reviewed-on: https://chromium-review.googlesource.com/655359 Reviewed-by: Victor Miura <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#502051}(cherry picked from commit 9ce9bad) Reviewed-on: https://chromium-review.googlesource.com/668896 Reviewed-by: Eric Karl <[email protected]> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#251} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove following resources:
used, thus it could be overriden by web developers.
This patch is the backport from Crosswalk-lite
BUG=https://crosswalk-project.org/jira/browse/XWALK-3928
TEST=Build with/without flag use_minimum_resources and simple test on XWalkCoreShell.apk
SIZE_REDUCED=212k(Release build on ARM)