This repository was archived by the owner on Apr 3, 2020. It is now read-only.
[Temp][oz-wl] Fix undefined references for NativeViewAccessibility #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just like we did for .xwalk/, ignore the ozone/ directory (it also prevents it from being deleted if one runs gclient sync with -D).
Since each DesktopNativeWidgetAura uses a sole aura::Window as its backed, once the title of native widget gets updated, the title of aura::Window should also be updated in addition to updating the XWindow created by DesktopRootWindowHostX11. BUG=crosswalk-project/crosswalk#191 TEST=xwalk_browsertest --gtest_filter=XWalkRuntimeTest.GetWindowTitle Conflicts: ui/views/widget/desktop_aura/desktop_native_widget_aura.cc Rework with 34.0.1847.45 code base
Chromium uses the sourceid of a XIDeviceEvent to decide if it is orignated from a touch device. See events_x.cc:717. However, Chromium uses deviceid to check touch device. See touch_factory_x11.cc:158. As X11 spec, only slave device has same sourceid and device id. So Chromium should setup touch device list with XISlavePointer other than XIMasterPointer device. TESTS=https://github.com/borismus/MagicTouch/blob/master/samples/tracker.html
SetProcessTitleFromCommandLine() plays a role to change process title to absolute path of the executable with arguments that the CommandLine object has. For example, we want gpu process title to be "<xwalk dir>/xwalk --type=gpu-process", not "/proc/self/exe --type=gpu-process" However, we don't want to change browser process title, because browser process title should be web app symbolic link path, not xwalk executable absolute path. SandboxIPC process is the process forked by browser process. We want that SandboxIPC process title is different from browser process title. Otherwise, Tizen task switcher misunderstands that SandboxIPC process is also web application process. To achieve it, 1. Browser process must not call SetProcessTitleFromCommandLine(); 2. Browser process must save argv pointer to change SandboxIPC process title later. 3. SandboxIPC process also calls SetProcessTitleFromCommandLine() to change its own process title. BUG=crosswalk-project/crosswalk#609 Reworked for 35.0.1908.4
For android trybots, they will use emulator to run tests. On emulator, the operation will take really a lot of time.
It randomly happens that adb devices return empty list even device is actually connected, killing adb and restart it can fix this. CL=https://codereview.chromium.org/24194002 Reworked for 37.0.2062.3
Based on patch from: Kenneth Rohde Christiansen <[email protected]> Since we have enabled overlay scrollbars we now get the desktop behavior, which means that a thin scroll indicator is always visible, which immediately grows when scrolling and shrinks (animated) back to the small size when scrolling is over. On Tizen we want a different behavior: a) no scroll indicator when not scrolling b) a think scroll indicator which is slightly offset from the right viewport edge c) the scroll indicator should fade out (animated) when the scroll is over This patch is changing the scrollbar animator to 'fade out' and fixes 'a)' and 'c)' from the list above.
This includes disabling site themed scrollbars (we use overlay scrollbars always), enabling double tap to zoom for zoomable pages, disable auto playing of music (a touch is needed) as well as moving input fields into the view when focused. It also enables the fade out scrollbars on all Tizen platforms, not just mobile.
Introduced by src@225471
…ties API We need these functions in to get the list of Codecs available in the system for getAVCodecs(). If we ever fork ffmpeg, we can just remove this patch and add the signatures directly at the ffmpeg's signature list.
Fix scrollbar lengths so that they match up with the size of the content.
The shared pref here is to save the status for pak file extraction. Since the pak file is extracted to each app's data folder, the prefs also needs to be saved for each app individually. For crosswalk usage, in shared mode, the context in ResourceExtractor is the context for library apk. Use the application context of it to get the app's context. BUG=https://crosswalk-project.org/jira/browse/XWALK-228
…as global functions Make CodecIDToAudioCodec and CodecIDToVideoCodec available as global functions so that they can be used by Device Capabilities getAVCodecs() interface to query the list of supported codecs.
This patch allow us to customize the _NET_WM_PID property of a X11 window that is backing a views::Widget. A new attribute was added to InitParams that contains the new value, if not set, the PID of the current running process is used. The reason for having this ability is to make Task Manager able to raise the right X11 window when one "running application" is selected. In Tizen Mobile, we use a shared browser process, that will create all the windows, and the homescreen launches a different program that will trigger the launch in the shared browser process. To make Task Manager work properly we need to set the _NET_WM_PID of the windows we create to the appropriate PID of the program Since both Linux Desktop and Tizen Mobile use the DesktopWindowTreeHostX11, we don't change DesktopWindowTreeHost. Rework with 42.0.2302.0 code base.
On Android ICS, the max number of thread local storage is limited to 64. Chromium TLS provides a mechanism to support large number of TLS slots which is independent of OS restictions. This commit is to make sure the ThreadLocalPointer uses the Chromium TLS mechnism instead of directly calling pthread_create_key, so that it can avoid the crash if the number of TLS slots allocated exceeds the max number allowed by OS. BUG=https://crosswalk-project.org/jira/browse/XWALK-841
Embedders may want to put paks in res/raw instead of assets. Because for Android Library project, assets is not handled well. Add intercepter in ResourceExtractor to allow embedder to provide the interceptable resources' list and the inputstream to intercept with.
This commit is not upstreamable, check details at https://codereview.chromium.org/15955009/. It can be mreged with previous libva patchset d660a3e Enabling Hardware Acceleration with Libva in linux-x86.
Chromium class inherits from Application directly. This is not suitable for Crosswalk embedding API. Instead, define a new API which can pass Application instance as the parameter instead of asking users' application inheriting from Chromium Application. This fix is due to the change in upstream: https://codereview.chromium.org/159173002
We have un-necessary dependency on views. This is a temporary patch to include desktop_aura/ as part of view target. [This is oz-wl's 0003-Add-support-to-provide-external-ozone-files-in-views.patch.]
…atusManager When ApplicationStatus initialized after application started, the onActivityCreated(), onActivityStarted() and onActivityResumed() callbacks will be missed. This function will give the chance to simulate these three callbacks. BUG=XWALK-1366
Currently, Crosswalk for Ozone-wayland shows the title bar by default on IVI. As a result, when webapps enter fullscreen mode using HTML5 fullscreen API, their title bar still exist. This patch allows to hide the title bar in fullscreen mode. BUG=XWALK-896
The leak is fixed by commit "Make the ResourceExtractor use the App context"(0f1465d), which is reverted because xwalk shared mode needs to keep original Context. In this commit, the static instance of ResourceExtractor will be released after the background job is done. The ResourceExtractor should not be used any more from that point.
When activity_1 start activity_2(contains XWalkView), ApplicationStatus will start tracking when XWalkView initialized, But ApplicationStatus will receive status such as onStop from activity_1, we do not need track activity_1, just ignore it. For upstream, there is no such kind of case, ApplicationStatus will track all activities inside the package. BUG=XWALK-1454
Why: There are requirements to customize the MediaPlayer resource
loading on Android which is implemented in Chromium code base.
Till now we have two points:
1) Support the file:///android_asset in MediaPlayer.
2) Support app scheme in the resource loading of MediaPlayer.
Unfortunately, the resource loading of MediaPlayer on Andoid goes
a different way from other ports and no interface to handle this.
How: Add a new interface ResourceLoadingFilter to filter the resource
loading(setDataSource) in MediaPlayerBridge, which could be used in
xwalk to do the customization by overriding the function of
shouldOverrideResourceLoading() in xwalk.
BUG=https://crosswalk-project.org/jira/browse/XWALK-880
Use glib main loop when building Ozone (not only for the extension process). This will make glib based external extensions work when disabling the extension process.
Crash happens when releasing the audio resource of localusermedia in openSL ES. On Android there are two ways to get the audio input: openSL ES and java Recording API. We swtich to the Recording API as a workaround of the bug. The limitation is Recording API only be avaiable after version 15 of SDK. BUG=XWALK-1833
This patch set the resource set "name" property instead of "appid" as defined in the Murphy. BUG=TC-1731
This is highly experimental. Eventually, the goal is to only have platform specific parts in Wayland and core implementation as part of Chromium. Once, we have more matured implementation, initiate discussion upstream. (This patch is ozone-wayland's 0002-Remove-usage-of-DesktopFactory.patch).
This is temporary, so we can avoid gl circular dependency. Eventually, we want to be as aligned as possible with upstream Media solution and need to figure out how we could use upstream VaapiWrapper (while able to generate custom va_stubs if possible?). (This is oz-wl's 0005-Media-Build-VaapiPictureWayland-as-part-of-Media.patch).
This patch includes Chromium side changes that are needed for integrating WebMediaPlayer with the Murphy resource policy daemon.
We support notifications in Android but upstream doesn't so we should make sure they are enabled. We should really consider if the "desktop" notifications are the way forward for us in Android now that we have ServiceWorker and push notifications. https://codereview.chromium.org/920153002 BUG=XWALK-3653
Buffer swapping should not be synchronized so that the GPU process is not blocked by waiting for a frame update from Weston. BUG=TC-341 (This is oz-wl's 0008-Fix-crash-when-switching-to-console-VT-mode.patch.) It is not clear from ozone-wayland's pull request #300 if this change has been submitted upstream.
…er APIs vaLockBuffer APIs are obsolete. This change will use vaAcquireBufferHandle APIs to instead of vaLockBuffer APIs. VA-API version: >= 0.36 (libva 1.4.0) (This is ozone-wayland's 0012-Use-vaAcquireBufferHandle-APIs-to-instead-of-vaLockB.patch)
(This is ozone-wayland's 0013-Media-Use-upstream-Video-Accelerator.patch)
Requiring users to manually download Android SDK Extras is a step backwards for automation. We do not use them in Crosswalk or in our content_shell builds, so for now simply make things work without these files: * Make download_sdk_extras.py do nothing instead of timing out, as Crosswalk's bots set CHROME_HEADLESS=1 but the files this script tries to fetch are only accessible from Google's network. * Make the calls to find(1) in java.gypi create the directories before entering them. This is what was causing gyp to fail before even if we never depended on the targets requiring the SDK Extras ourselves. Hopefully we can work together with upstream to make the situation easier to manage.
Use this API to control whether the SurfaceView's surface is placed on top of its window. Note this only works when SurfaceView is used. For TextureView, it doesn't work. Related to XWALK-3778,XWALK-3742
Upstream recently enabled support for notifications and Push API on Android >= Jelly Bean (see commit d948e02, "Exceptions for enabling Web Notifications and the Push API by default"). Our support for notifications in Crosswalk is currently simpler (more similar to desktop-style notifications) and works on ICS devices as well, so we can be more lax about which devices we actually support. BUG=XWALK-3654
Due to licensing issues, the pre-built binary doesn't ship with the necessary codecs for patented media formats. Therefore, mp4/mp3 files can't be played back by Crosswalk. Add a command line option so that mp4/mp3 files can be played by loading the proprietary library. An example is, xwalk --proprietary-codec-lib-path=/opt/google/chrome/libffmpegsumo.so
The implementation fixed issue of mutual dependency of 'media' and 'content' module.
on various search it's not working well. Master of Chromium doesn't have this line, neither M42 so I would assume we picked up some bad revision in here.
…reate Also fix undefined reference for AXPlatformNode::Create
|
|
|
@kalyankondapally fyi, this is probably needed for standalone oz-wl builds too |
|
I've adopted @kalyankondapally's solution instead, and pushed together with a rebased chromium-crosswalk tracking 43.0.2357.18. |
rakuco
pushed a commit
that referenced
this pull request
Apr 30, 2015
Refactor DisplayInfo::rotation_ to track different sources of rotations Currently DisplayInfo only tracks the active rotation for the given display. DisplayPreferences however saves a user rotation, as well as an accelerometer rotation. DisplayController::Observer::OnDisplayConfigurationChanged triggers the saving of display preferences. This has been leading to active accelerometer rotations being saved as user preferences, and being re-applied upon reboot. This change refactors DisplayInfo to track one rotation per source of rotation changes. DisplayPreferences has been updated to save based on these states. TEST=DisplayPreferencesTest.DontSaveMaximizeModeControllerRotations, also ran ash_unittests, and unit_tests BUG=chrome-os-partner:37555, 469752, 466861 [email protected], [email protected], [email protected] NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1071353003 Cr-Commit-Position: refs/heads/master@{#326614} (cherry picked from commit d01de7f) Review URL: https://codereview.chromium.org/1107383002 Cr-Commit-Position: refs/branch-heads/2357@{#248} Cr-Branched-From: 59d4494-refs/heads/master@{#323860}
rakuco
pushed a commit
that referenced
this pull request
Aug 13, 2015
This is a small fix, missing a pair of brackets of "if" statement for issue 1186833005: Fix touch screen on Linux with or without flag --touch-devices (https://codereview.chromium.org/1186833005/) BUG=486492 Review URL: https://codereview.chromium.org/1230353002 Cr-Commit-Position: refs/heads/master@{#338553} (cherry picked from commit db63904) Review URL: https://codereview.chromium.org/1276933002 . Cr-Commit-Position: refs/branch-heads/2454@{#248} Cr-Branched-From: 12bfc33-refs/heads/master@{#338390}
mrunalk
pushed a commit
that referenced
this pull request
Sep 22, 2015
Disable it for Mali-400 where Android is 4.3 or older, and on VideoCore IV GPUs, since it seems to cause crashes, (or rather watchdog timeouts and unresponsiveness). BUG=496438,457914 NOTRY=True Review URL: https://codereview.chromium.org/1335323002 Cr-Commit-Position: refs/heads/master@{#348504} (cherry picked from commit 25a40be) Review URL: https://codereview.chromium.org/1344713002 . Cr-Commit-Position: refs/branch-heads/2490@{#248} Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
mrunalk
pushed a commit
that referenced
this pull request
Dec 18, 2015
If a tooltip is closed by a keyboard event and the mouse cursor was not moved, the same tooltip was shown again after some delay only on Windows. Blink receives native mousemove events repeatedly on Windows even if the mouse cursor is not moved. ChromeClient saves the last tooltip string and the last mouse position, and do not call virtual setToolTip() if they are not changed. This CL not only fixes the bug, but also reduces unnecessary IPC messages for tooltip. BUG=557660 TEST=automated Review URL: https://codereview.chromium.org/1500813004 Cr-Commit-Position: refs/heads/master@{#363174} (cherry picked from commit 91db68e) Review URL: https://codereview.chromium.org/1504743002 . Cr-Commit-Position: refs/branch-heads/2564@{#248} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
rakuco
pushed a commit
that referenced
this pull request
Mar 3, 2016
Previously MR relies on the behavior of route response returning a local displayable route on success. This is no longer the case, thus the logic to turn the toolbar icon blue is no longer getting triggered. The fix is to have the toolbar observe route list directly for local displayable routes. Route queries have a much lower overhead than before. In a separate patch we will clean up the now obsolete LocalMediaRoutesObserver API from MR and MR extension. BUG=582278 Review URL: https://codereview.chromium.org/1648713004 Cr-Commit-Position: refs/heads/master@{#372750} (cherry picked from commit 7f297c0) Review URL: https://codereview.chromium.org/1661623002 . Cr-Commit-Position: refs/branch-heads/2623@{#248} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
May 17, 2016
This CL fixes a regression caused by https://crrev.com/1660273003 which enables the buttons of the Find-In-Page bar even if no text is entered or no search was issued yet. [email protected] BUG=594097 TEST=FindInPageTest.ButtonsDisabledWithoutText Review URL: https://codereview.chromium.org/1785033004 Cr-Commit-Position: refs/heads/master@{#381074} (cherry picked from commit afc0733) Review URL: https://codereview.chromium.org/1801313003 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#248} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin
pushed a commit
to huningxin/chromium-croswalk
that referenced
this pull request
Oct 9, 2016
This CL is a strength of https://codereview.chromium.org/1952853005/. BUG=607695 Review-Url: https://codereview.chromium.org/2032043002 Cr-Commit-Position: refs/heads/master@{#398097} (cherry picked from commit 93018d6) Review URL: https://codereview.chromium.org/2041093003 . Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#248} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto
pushed a commit
to tenta-browser/chromium-crosswalk
that referenced
this pull request
Nov 2, 2017
The bug was fixed in iOS 11. This reverts most part of https://chromium-review.googlesource.com/c/chromium/src/+/608227 [email protected] (cherry picked from commit fb15ca6) Bug: 762869 Change-Id: I364b03deda2c8e56023bbd25a128d3bcb5ca7903 Reviewed-on: https://chromium-review.googlesource.com/655237 Reviewed-by: Justin Cohen <[email protected]> Reviewed-by: Elodie Banel <[email protected]> Commit-Queue: Olivier Robin <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#500585} Reviewed-on: https://chromium-review.googlesource.com/668537 Reviewed-by: Olivier Robin <[email protected]> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#248} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix undefined reference for AXPlatformNode::Create