Add the command line option to load proprietary codec library. #244

shaochangbin · 2015-03-30T05:38:14Z

Due to licensing issues, the pre-built binary doesn't ship with the
necessary codecs for patented media formats. Therefore, mp4/mp3 files
can't be played back by Crosswalk.

Add a command line option so that mp4/mp3 files can be played by loading
the proprietary library. An example is,
xwalk --proprietary-codec-lib-path=/opt/google/chrome/libffmpegsumo.so

crosswalk-trybot · 2015-03-30T05:38:16Z

Testing patch series with shaochangbin/chromium-crosswalk@a3a2ff1 as its head.

Bot	Status
Content Shell Linux	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Linux/builds/172)
Content Shell Android-x86	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Android-x86/builds/173)

shaochangbin · 2015-03-30T05:40:07Z

@rakuco @seanlong @halton PTAL.
The case is similar with below discussion,
[ https://github.com/nwjs/nw.js/wiki/Using-MP3-&-MP4-(H.264)-using-the--video--&--audio--tags. ]

halton · 2015-03-30T07:18:38Z

content/browser/zygote_host/zygote_host_impl_linux.cc

@@ -140,6 +140,7 @@ void ZygoteHostImpl::Init(const std::string& sandbox_cmd) {
    switches::kRegisterPepperPlugins,
    switches::kV,
    switches::kVModule,
+    switches::kProprietaryCodecLibPath,


halton · 2015-03-30T07:21:51Z

LGTM with the nits comments.

Due to licensing issues, the pre-built binary doesn't ship with the necessary codecs for patented media formats. Therefore, mp4/mp3 files can't be played back by Crosswalk. Add a command line option so that mp4/mp3 files can be played by loading the proprietary library. An example is, xwalk --proprietary-codec-lib-path=/opt/google/chrome/libffmpegsumo.so

crosswalk-trybot · 2015-03-30T07:57:02Z

Testing patch series with shaochangbin/chromium-crosswalk@672d42f as its head.

Bot	Status
Content Shell Linux	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Linux/builds/173)
Content Shell Android-x86	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Android-x86/builds/174)

shaochangbin · 2015-03-30T08:59:26Z

Fix the nits. Thanks for your comments @halton

halton · 2015-03-30T09:12:26Z

LGTM

darktears · 2015-03-30T11:43:12Z

Let's make sure it's documented.

Add the command line option to load proprietary codec library.

shaochangbin · 2015-03-31T04:59:01Z

@darktears , could you please point out the place where I should put the document?
Thanks!

halton · 2015-03-31T06:13:15Z

https://github.com/crosswalk-project/crosswalk-website/wiki/Crosswalk-Command-Line-Options

shaochangbin · 2015-04-01T02:07:34Z

Thanks! @halton
Updated the wiki page.

rakuco · 2015-04-02T08:41:37Z

I think this needs to be reverted or reworked.

This has broken the component=shared_library build:

obj/media/base/media.media_posix.o:media_posix.cc:function media::internal::InitializeMediaLibraryInternal(base::FilePath const&): error: undefined reference to 'switches::kProprietaryCodecLibPath'
obj/media/base/media.media_posix.o:media_posix.cc:function media::internal::InitializeMediaLibraryInternal(base::FilePath const&): error: undefined reference to 'switches::kProprietaryCodecLibPath'
obj/media/base/media.media_posix.o:media_posix.cc:function media::internal::InitializeMediaLibraryInternal(base::FilePath const&): error: undefined reference to 'switches::kProprietaryCodecLibPath'

Basically you are using a symbol from content/ in media/ which does not work if you build those targets as separate shared libraries, and you cannot make the latter depend on the former because the former depends on the latter.

shaochangbin · 2015-04-02T09:23:42Z

@rakuco Thanks a lot for raising this! I'll provide fix later.

This is a more extensive version of http://crrev.com/1075343003 for landing on trunk. Previously, if isSyncable is false, but sync is enabled for Chrome, even if you sign in, Chrome would never set syncable to true. This CL ensures that syncable is always set to true if there is an account signed in, regardless of whether chrome sync is enabled or not. Additionally, it sets syncable to false when no account is signed in, to ensure that the user does not see a non-functional switch in the Android settings. The new AccountManager setup in the test is necessary so that the test accounts can be cleaned up by the loop in updateSyncability(). BUG=475299 TEST=Regression tests added, plus: Ensure that $ adb shell dumpsys content | grep chrome should show syncable=0 and enabled=true Sign in to Chrome. Now dumpsys should say syncable=1 and enabled=true. Review URL: https://codereview.chromium.org/1062973004 Note: this commit replaces 3d3e24b (https://codereview.chromium.org/1075343003) [email protected] Cr-Commit-Position: refs/heads/master@{#326122} (cherry picked from commit fd45731) Review URL: https://codereview.chromium.org/1109013002 Cr-Commit-Position: refs/branch-heads/2357@{#244} Cr-Branched-From: 59d4494-refs/heads/master@{#323860}

…lt." This reverts commit 709a387. Cr-Commit-Position: refs/branch-heads/2454@{#244} Cr-Branched-From: 12bfc33-refs/heads/master@{#338390}

Re-land: Enable GpuMemoryBuffers video frames on MacOS. This patch enables UYVY GpuMemoryBuffers backed VideoFrames on MacOSX for software decoded videos. This change allows VideoLayers to be promoted to overlays when possible. Power measurements showed a significant reduction in Watts consumed during video playback: in the tests ran by ccameron@ it went from 3.15 Watts to 2.13 Watts. Additionally this change avoids one copy of the VideoFrame in the GPU process and moves away another copy from the Compositor thread to media. Unfortunately, for videos where the decoding time is close to the frame time, the additional copy might slow down the decoding past the limit, causing more dropped frames in these cases. More benchmark results can be found here: https://x20web.corp.google.com/~dcastagna/results_all.html The first run is with GMB video frames disabled, the second one, enabled. BUG=485859,510252 Committed: https://crrev.com/96463459619f441a721f96c51c357208604b7475 Cr-Commit-Position: refs/heads/master@{#345418} Review URL: https://codereview.chromium.org/1308913003 Cr-Commit-Position: refs/heads/master@{#347566} (cherry picked from commit b65e607) BUG=510252 Review URL: https://codereview.chromium.org/1345453006 . Cr-Commit-Position: refs/branch-heads/2490@{#244} Cr-Branched-From: 7790a35-refs/heads/master@{#344925}

Cr-Commit-Position: refs/branch-heads/2564@{#244} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}

…bubble The toolbar icon surfacing bubble shows up the first time the user runs the browser with the --extension-action-redesign feature. There's a race condition in the mac code where if the browser window starts up before the extension system is ready, the code incorrectly infers that there are no new extensions, and doesn't show the bubble. Fix this, and add a test. BUG=582512 Review URL: https://codereview.chromium.org/1643963003 Cr-Commit-Position: refs/heads/master@{#372410} (cherry picked from commit 213c3cf) Review URL: https://codereview.chromium.org/1659993002 . Cr-Commit-Position: refs/branch-heads/2623@{#244} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}

Slow connections, large MediaSource appends, or open-in-background can result in large delays from when the WMP is constructed until it reaches a state appropriate for suspension. Waiting until we have the first frame and size information to mark a player as idle should resolve any issues around suspending too early. BUG=592706 TEST=fixed unittests. Suspend does not occur w/ open-in-background. Review URL: https://codereview.chromium.org/1796403002 Cr-Commit-Position: refs/heads/master@{#381156} (cherry picked from commit 8e4dc68) Review URL: https://codereview.chromium.org/1808463002 . Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#244} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}

…allpaper. Merge this CL to M52 on behalf of xiaoyinh@. This change is to fill the canvas with black background every time before painting a new wallpaper, so that the new wallpaper with partial transparency won't be painted upon a previous wallpaper. BUG=606434 [email protected], [email protected] Review-Url: https://codereview.chromium.org/1996793002 Cr-Commit-Position: refs/heads/master@{#395175} (cherry picked from commit 5fb5760) Review URL: https://codereview.chromium.org/2039173003 . Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#244} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}

This is a temporal fix for the issue that non-Latin IMEs doesn't work. The 'background.persistent' flag should be restored as soon as possible after fixing the root cause of the issue. Also, add some useful logs to debug the issue. chrome://inspect/#extensions. [email protected] (cherry picked from commit 6932703) Bug: 761714 Test: Manual. Confirm that the extension always appears on Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia0a12a33036919dc2bec213fd11b49d3b7b9d54f Reviewed-on: https://chromium-review.googlesource.com/660938 Commit-Queue: Yuichiro Hanada <[email protected]> Reviewed-by: Shu Chen <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#501211} Reviewed-on: https://chromium-review.googlesource.com/668271 Reviewed-by: Yuichiro Hanada <[email protected]> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#244} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}

halton reviewed Mar 30, 2015
View reviewed changes

shaochangbin force-pushed the proprietary-codec branch from a3a2ff1 to 672d42f Compare March 30, 2015 07:57

darktears added a commit that referenced this pull request Mar 30, 2015

Merge pull request #244 from shaochangbin/proprietary-codec

70df207

Add the command line option to load proprietary codec library.

darktears merged commit 70df207 into crosswalk-project:master Mar 30, 2015

mrunalk pushed a commit that referenced this pull request Dec 18, 2015

Incrementing VERSION to 48.0.2564.34

73a5c16

Cr-Commit-Position: refs/branch-heads/2564@{#244} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add the command line option to load proprietary codec library. #244

Add the command line option to load proprietary codec library. #244

Uh oh!

shaochangbin commented Mar 30, 2015

Uh oh!

crosswalk-trybot commented Mar 30, 2015

Uh oh!

shaochangbin commented Mar 30, 2015

Uh oh!

halton Mar 30, 2015

Uh oh!

halton commented Mar 30, 2015

Uh oh!

crosswalk-trybot commented Mar 30, 2015

Uh oh!

shaochangbin commented Mar 30, 2015

Uh oh!

halton commented Mar 30, 2015

Uh oh!

darktears commented Mar 30, 2015

Uh oh!

shaochangbin commented Mar 31, 2015

Uh oh!

halton commented Mar 31, 2015

Uh oh!

shaochangbin commented Apr 1, 2015

Uh oh!

rakuco commented Apr 2, 2015

Uh oh!

shaochangbin commented Apr 2, 2015

Uh oh!

Uh oh!

Add the command line option to load proprietary codec library. #244

Add the command line option to load proprietary codec library. #244

Uh oh!

Conversation

shaochangbin commented Mar 30, 2015

Uh oh!

crosswalk-trybot commented Mar 30, 2015

Uh oh!

shaochangbin commented Mar 30, 2015

Uh oh!

halton Mar 30, 2015

Choose a reason for hiding this comment

Uh oh!

halton commented Mar 30, 2015

Uh oh!

crosswalk-trybot commented Mar 30, 2015

Uh oh!

shaochangbin commented Mar 30, 2015

Uh oh!

halton commented Mar 30, 2015

Uh oh!

darktears commented Mar 30, 2015

Uh oh!

shaochangbin commented Mar 31, 2015

Uh oh!

halton commented Mar 31, 2015

Uh oh!

shaochangbin commented Apr 1, 2015

Uh oh!

rakuco commented Apr 2, 2015

Uh oh!

shaochangbin commented Apr 2, 2015

Uh oh!

Uh oh!