Skip to content
This repository was archived by the owner on Apr 3, 2020. It is now read-only.

[Lite] To disable Mediastream #98

Merged

Conversation

PeterWangIntel
Copy link

Flag = disable_mediastream
Reduced size = 30K

@PeterWangIntel
Copy link
Author

@heke123 @halton

@@ -320,6 +320,12 @@
'WebMediaPlayerClientImpl.cpp',
'WebMediaPlayerClientImpl.h',
],
'web_files_mediastream': [
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't find this "web_files_mediastream" be referenced anywhere. I guess it should be used in "web.gyp"?

@heke123
Copy link

heke123 commented Nov 13, 2015

Also advice to delete the out dir, and rebuild all, as we discussed that sometimes the build env is not clean.

@PeterWangIntel PeterWangIntel changed the title To disable Mediastream [Lite] To disable Mediastream Nov 19, 2015
Flag = disable_mediastream
Reduced Size = 30K
@PeterWangIntel
Copy link
Author

@heke123
It's been updated. Thank you for your comments.
The pair patch in Chromium is crosswalk-project/chromium-crosswalk#300

@heke123
Copy link

heke123 commented Nov 19, 2015

LGTM

halton pushed a commit that referenced this pull request Nov 19, 2015
@halton halton merged commit e1aaba5 into crosswalk-project:crosswalk-lite Nov 19, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants