-
Notifications
You must be signed in to change notification settings - Fork 407
Cannot compile ring 0.17.13 (also reqwest) due to outdated bintools #1639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We have encountered the same issue. |
Does it work if you specify #Cross.toml
[target.x86_64-unknown-illumos]
image = "ghcr.io/cross-rs/x86_64-unknown-illumos:main" |
Actually we're using cross from the github repo by compiling it, so I doubt it'll help |
You can pin ring to 0.17.12 for now |
@Emilgardis Can we safely expect that upgrading binutils in the current dockerfile will not affect existing projects? |
it would affect other projects, but that's unavoidable. Feel free to make a pr to bump the version |
hey @Emilgardis I encountered same issue with https://github.com/foundry-rs/foundry/actions/runs/13736635946/job/38421111790#step:10:142 |
@grandizzy No, the 0.2.5 image won't be updated. binutils should be versioned high enough on |
This doesn't only affect illumos but also plain old x86_64-unknown-linux-gnu. Would perhaps be good to change the labels. x86_64-unknown-linux-musl is not affected though. |
thank you. Are there plans to do a new release? We're using https://github.com/taiki-e/install-action gh action to install and it gets the latest one which is 0.2.5. |
@grandizzy Please see #1290 about the current situation. I would love to make a release.
If it doesn't work on |
Ah yes, it does work with |
In briansmith/ring#2462 (comment), @azjezz wrote:
|
Eric Biggers mentioned to me that VPCLMULQDQ support was added in binutils version 2.30 (released in January 2018). So potentially any binutils version less than 2.30 will be tool old to compile ring for x86_64. docker/solaris.sh mentions 2.28.1, as does docker/illumos.sh.. |
Are there any stable tags for the images that can be used, instead of |
You can specify a @sha: tag, so for x86_64-unknown-linux-gnu you could use They are stable in the sense that they won't change. illumos is currently being built here, solaris will fail due to other issues, will try to fix it. edit: illumos is now available as |
Checklist
Describe your issue
Cross is unable to compile ring 0.17.13 due to outdated bintools in the
x86_64-unknown-illumos
docker image.Possible Solutions:
What target(s) are you cross-compiling for?
other (specify in description)
Which operating system is the host (e.g computer cross is on) running?
What architecture is the host?
What container engine is cross using?
cross version
cross 0.2.5
Example
No response
Additional information / notes
No response
The text was updated successfully, but these errors were encountered: