Skip to content

Cannot compile ring 0.17.13 (also reqwest) due to outdated bintools #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 of 11 tasks
ahqsoftwares opened this issue Mar 7, 2025 · 17 comments · Fixed by #1641
Closed
4 of 11 tasks

Cannot compile ring 0.17.13 (also reqwest) due to outdated bintools #1639

ahqsoftwares opened this issue Mar 7, 2025 · 17 comments · Fixed by #1641
Labels
A-illumos Area: Illumos A-solaris Area: solaris targets

Comments

@ahqsoftwares
Copy link
Contributor

ahqsoftwares commented Mar 7, 2025

Checklist

Describe your issue

Cross is unable to compile ring 0.17.13 due to outdated bintools in the x86_64-unknown-illumos docker image.

Possible Solutions:

What target(s) are you cross-compiling for?

other (specify in description)

Which operating system is the host (e.g computer cross is on) running?

  • macOS
  • Windows
  • Linux / BSD
  • other OS (specify in description)

What architecture is the host?

  • x86_64 / AMD64
  • arm32
  • arm64 (including Mac M1)

What container engine is cross using?

  • docker
  • podman
  • other container engine (specify in description)

cross version

cross 0.2.5

Example

No response

Additional information / notes

No response

@qianyiwen2019
Copy link

We have encountered the same issue.
Is there a temporary/quick workaround on cross 0.2.5 ?

@Emilgardis
Copy link
Member

Does it work if you specify

#Cross.toml
[target.x86_64-unknown-illumos]
image = "ghcr.io/cross-rs/x86_64-unknown-illumos:main"

@ahqsoftwares
Copy link
Contributor Author

Actually we're using cross from the github repo by compiling it, so I doubt it'll help

@ahqsoftwares
Copy link
Contributor Author

Image

this is the version of binutils in cross-rs/cross

@Emilgardis Emilgardis added the A-illumos Area: Illumos label Mar 7, 2025
@ahqsoftwares
Copy link
Contributor Author

ahqsoftwares commented Mar 8, 2025

We have encountered the same issue.
Is there a temporary/quick workaround on cross 0.2.5 ?

You can pin ring to 0.17.12 for now

@ahqsoftwares
Copy link
Contributor Author

@Emilgardis Can we safely expect that upgrading binutils in the current dockerfile will not affect existing projects?

@Emilgardis
Copy link
Member

it would affect other projects, but that's unavoidable. Feel free to make a pr to bump the version

@grandizzy
Copy link

grandizzy commented Mar 8, 2025

hey @Emilgardis I encountered same issue with ghcr.io/cross-rs/x86_64-unknown-linux-gnu:0.2.5 image, will binutils be bumped for those too? thank you!

https://github.com/foundry-rs/foundry/actions/runs/13736635946/job/38421111790#step:10:142

@Emilgardis
Copy link
Member

@grandizzy No, the 0.2.5 image won't be updated. binutils should be versioned high enough on :main though

@VorpalBlade
Copy link

VorpalBlade commented Mar 8, 2025

This doesn't only affect illumos but also plain old x86_64-unknown-linux-gnu. Would perhaps be good to change the labels.

x86_64-unknown-linux-musl is not affected though.

@grandizzy
Copy link

@grandizzy No, the 0.2.5 image won't be updated. binutils should be versioned high enough on :main though

thank you. Are there plans to do a new release? We're using https://github.com/taiki-e/install-action gh action to install and it gets the latest one which is 0.2.5.

@Emilgardis
Copy link
Member

@grandizzy Please see #1290 about the current situation. I would love to make a release.

Would perhaps be good to change the labels.

If it doesn't work on ghcr.io/cross-rs/x86_64-unknown-linux-gnu:main then yes I'd agree @VorpalBlade, but I suspect it does work, haven't checked myself though

@VorpalBlade
Copy link

Ah yes, it does work with :main, but since that isn't default, that is still a workaround that needs to be done.

@briansmith
Copy link
Contributor

In briansmith/ring#2462 (comment), @azjezz wrote:

I just encountered the same issue cross compiling for linux: https://github.com/carthage-software/mago/actions/runs/13735422342/job/38418652700

updated for those having similar issue: we simply disabled cross for the failing target, and it works: carthage-software/mago@12beb0c

@briansmith
Copy link
Contributor

Eric Biggers mentioned to me that VPCLMULQDQ support was added in binutils version 2.30 (released in January 2018). So potentially any binutils version less than 2.30 will be tool old to compile ring for x86_64.

docker/solaris.sh mentions 2.28.1, as does docker/illumos.sh..

@Emilgardis Emilgardis added the A-solaris Area: solaris targets label Mar 8, 2025
@briansmith
Copy link
Contributor

Are there any stable tags for the images that can be used, instead of main, that will reliably pick up these changes?

@Emilgardis
Copy link
Member

Emilgardis commented Mar 8, 2025

Are there any stable tags for the images that can be used, instead of main, that will reliably pick up these changes?

You can specify a @sha: tag, so for x86_64-unknown-linux-gnu you could use ghcr.io/cross-rs/x86_64-unknown-linux-gnu@sha256:25e3a1b7d4a57ff9326d69a302005e909014e48f7995b70a2feaa71faad469c5

They are stable in the sense that they won't change.

illumos is currently being built here, solaris will fail due to other issues, will try to fix it.

edit: illumos is now available as ghcr.io/cross-rs/x86_64-unknown-illumos:main or ghcr.io/cross-rs/x86_64-unknown-illumos@sha256:544df55cb27c1e09bd083de8b14259979bc82553ebbf8361b4efcf11d7363caf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-illumos Area: Illumos A-solaris Area: solaris targets
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants