Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows curl build >= 8.3 #660

Merged
merged 3 commits into from
Mar 20, 2025
Merged

Fix windows curl build >= 8.3 #660

merged 3 commits into from
Mar 20, 2025

Conversation

crazywhalecc
Copy link
Owner

@crazywhalecc crazywhalecc commented Mar 19, 2025

What does this PR do?

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php, run composer cs-fix at local machine.
  • If it's an extension or dependency update, make sure adding related extensions in src/global/test-extensions.php.
  • If you changed the behavior of static-php-cli, update docs in ./docs/.
  • If you updated config/xxx.json content, run bin/spc dev:sort-config xxx.

@crazywhalecc crazywhalecc added bug Something isn't working os/windows Things only for Windows labels Mar 19, 2025
@DubbleClick
Copy link
Collaborator

Why does it have to be renamed to libcurl_a.lib?

@crazywhalecc
Copy link
Owner Author

@DubbleClick
Copy link
Collaborator

Ah they're trying to differentiate between an object containing .lib and a link layer .lib to link against the shared dll. A bit of a weird way to do that, but we'll have to follow suit I guess.

@crazywhalecc crazywhalecc marked this pull request as ready for review March 19, 2025 14:38
@crazywhalecc crazywhalecc changed the title Test windows curl Fix windows curl build >= 8.3 Mar 19, 2025
@crazywhalecc
Copy link
Owner Author

crazywhalecc commented Mar 19, 2025

And then I think we should add weekly extension test for windows ASAP #601 . This problem should perhaps have been discovered earlier.

@crazywhalecc crazywhalecc merged commit 0bc143c into main Mar 20, 2025
8 checks passed
@crazywhalecc crazywhalecc deleted the windows-curl-test branch March 20, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working os/windows Things only for Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants