Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing ext source when downloading pre-built grpc #652

Merged
merged 2 commits into from
Mar 14, 2025

Conversation

crazywhalecc
Copy link
Owner

@crazywhalecc crazywhalecc commented Mar 14, 2025

What does this PR do?

Fix #606 .

CI should be failed as expected (except macos-14). Because the only fixed pre-built libs is grpc-aarch64-darwin.txz that I manually uploaded. After CI finished, it could be merged and hosted repo will trigger packing libs soon.

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php, run composer cs-fix at local machine.
  • If it's an extension or dependency update, make sure adding related extensions in src/global/test-extensions.php.
  • If you changed the behavior of static-php-cli, update docs in ./docs/.
  • If you updated config/xxx.json content, run bin/spc dev:sort-config xxx.

@crazywhalecc crazywhalecc added bug Something isn't working kind/framework Issues related to CLI app framework labels Mar 14, 2025
@crazywhalecc crazywhalecc merged commit b193105 into main Mar 14, 2025
10 of 20 checks passed
@crazywhalecc crazywhalecc deleted the fix/grpc-pre-built-source branch March 14, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working kind/framework Issues related to CLI app framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension grpc has build bug with --prefer-pre-built download option
1 participant