Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sodium extension support for Windows #651

Merged
merged 3 commits into from
Mar 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion config/ext.json
Original file line number Diff line number Diff line change
Expand Up @@ -674,7 +674,6 @@
},
"sodium": {
"support": {
"Windows": "wip",
"BSD": "wip"
},
"type": "builtin",
Expand Down
3 changes: 3 additions & 0 deletions config/lib.json
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,9 @@
"source": "libsodium",
"static-libs-unix": [
"libsodium.a"
],
"static-libs-windows": [
"libsodium.lib"
]
},
"libssh2": {
Expand Down
52 changes: 52 additions & 0 deletions src/SPC/builder/windows/library/libsodium.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
<?php

declare(strict_types=1);

namespace SPC\builder\windows\library;

use SPC\builder\windows\SystemUtil;
use SPC\exception\RuntimeException;
use SPC\store\FileSystem;

class libsodium extends WindowsLibraryBase
{
public const NAME = 'libsodium';

protected function build()
{
FileSystem::replaceFileStr($this->source_dir . '\src\libsodium\include\sodium\export.h', '#ifdef SODIUM_STATIC', '#if 1');
$vs_ver_dir = match (SystemUtil::findVisualStudio()['version']) {
'vs17' => '\vs2022',
'vs16' => '\vs2019',
default => throw new RuntimeException('Current VS version is not supported yet!'),
};

// start build
cmd()->cd($this->source_dir . '\builds\msvc\\' . $vs_ver_dir)
->execWithWrapper(
$this->builder->makeSimpleWrapper('msbuild'),
'libsodium.sln /t:Rebuild /p:Configuration=StaticRelease /p:Platform=x64 /p:PreprocessorDefinitions="SODIUM_STATIC=1"'
);
FileSystem::createDir(BUILD_LIB_PATH);
FileSystem::createDir(BUILD_INCLUDE_PATH);

// copy include
FileSystem::copyDir($this->source_dir . '\src\libsodium\include\sodium', BUILD_INCLUDE_PATH . '\sodium');
copy($this->source_dir . '\src\libsodium\include\sodium.h', BUILD_INCLUDE_PATH . '\sodium.h');
// copy lib
$ls = FileSystem::scanDirFiles($this->source_dir . '\bin');
$find = false;
foreach ($ls as $file) {
if (str_ends_with($file, 'libsodium.lib')) {
copy($file, BUILD_LIB_PATH . '\libsodium.lib');
$find = true;
}
if (str_ends_with($file, 'libsodium.pdb')) {
copy($file, BUILD_LIB_PATH . '\libsodium.pdb');
}
}
if (!$find) {
throw new RuntimeException('libsodium.lib not found');
}
}
}
17 changes: 8 additions & 9 deletions src/globals/test-extensions.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,18 +14,17 @@
// test php version
$test_php_version = [
'8.1',
// '8.2',
// '8.3',
'8.2',
'8.3',
'8.4',
];

// test os (macos-13, macos-14, ubuntu-latest, windows-latest are available)
$test_os = [
// 'macos-13',
// 'macos-14',
// 'ubuntu-latest',
'windows-2019',
'windows-latest',
'macos-13',
'macos-14',
'ubuntu-latest',
// 'windows-latest',
];

// whether enable thread safe
Expand All @@ -42,13 +41,13 @@
// If you want to test your added extensions and libs, add below (comma separated, example `bcmath,openssl`).
$extensions = match (PHP_OS_FAMILY) {
'Linux', 'Darwin' => 'gettext',
'Windows' => 'gd',
'Windows' => 'bcmath',
};

// If you want to test lib-suggests feature with extension, add them below (comma separated, example `libwebp,libavif`).
$with_libs = match (PHP_OS_FAMILY) {
'Linux', 'Darwin' => '',
'Windows' => 'libavif',
'Windows' => '',
};

// Please change your test base combination. We recommend testing with `common`.
Expand Down