-
-
Notifications
You must be signed in to change notification settings - Fork 291
Initial code to get Box for phar building, replace DeployCommand #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8e049b0
to
21195ab
Compare
After introducing box, it is a good choice to directly rewrite DeployCommand. Ideally, we can automatically package single executable SPC files for different platforms and upload them when releasing a new version:
|
@crazywhalecc Extracted this as a roadmap for rewrite: #179 |
a86601f
to
a692419
Compare
Are there any positive considerations for using the Version class? |
This comment was marked as outdated.
This comment was marked as outdated.
@crazywhalecc Removed the version class, Box was able to call the public const in the end. The workflow file was also removed. |
Failure unrelated requires a job re-run (probably an issue with GH actions). |
Info: