Skip to content

Customize the status bar color via @color/primary_dark #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 16, 2017
Merged

Customize the status bar color via @color/primary_dark #102

merged 3 commits into from
Oct 16, 2017

Conversation

lone-cloud
Copy link
Contributor

@lone-cloud lone-cloud commented Sep 28, 2017

#95

@lone-cloud lone-cloud changed the title Customize the status bar color via @color/primary_dark (#95) Customize the status bar color via @color/primary_dark Sep 28, 2017
@Palisand
Copy link

Palisand commented Oct 4, 2017

Hey, Mr. @hoboman313 play a song for me. Thank you for this contribution; hopefully it gets merged soon! You might also want to include an update to the README for people who aren't familiar with native Android development (such as myself). Something along the lines of:

Add <color name="primary_dark">#XXXXXX</color> to your app's strings.xml's <resources>.

… color when the splash screen is displayed
@lone-cloud
Copy link
Contributor Author

Good idea. Done.

@crazycodeboy crazycodeboy merged commit 77f8f3d into crazycodeboy:master Oct 16, 2017
@fqborges
Copy link

This is a breaking change, isn't? This is change is causing #124 because you need to add this colors.xml in your project.

Could you please bump the version to 4.x ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants