Skip to content

Fix broken links: Documentation about CrateDB Edge has been removed #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

amotl
Copy link
Member

@amotl amotl commented May 8, 2025

About

What the title says.

References

@amotl amotl requested review from bmunkholm and kneth May 8, 2025 11:31

This comment was marked as off-topic.

Copy link
Contributor

@bmunkholm bmunkholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@amotl amotl force-pushed the no-cloud-on-kubernetes branch from 719bbcb to f569af9 Compare May 8, 2025 11:35
@bmunkholm
Copy link
Contributor

@amotl For my education, I wonder if we don't have any link checking across the various documentation projects? And subsequent what the best practices are to ensure all links between doc projects are good?

@amotl
Copy link
Member Author

amotl commented May 8, 2025

For my education, I wonder if we don't have any link checking across the various documentation projects?

We do. It is exactly the link checker which was tripping on this occasion, as observed on your other patch GH-199. Of course, intersphinx references are special anyway and also trip regular documentation builds, that's why the RTD job also failed.

Using intersphinx references is the best way to quickly detect and resolve dangling reference pointer situations like this one, because it enforces strong links between otherwise independent projects, detecting any kinds of symbol errors on the same level like software linters are doing it, i.e.: It just will not build at all. In this spirit, relevant intersphinx mechanisms already built into Sphinx itself implicitly provide the best thing since sliced bread in this regard.

On the other hand, for validating the integrity of plain old HTTP link references, Sphinx offers a dedicated "linkcheck" builder, which is employed on our CI workflows across the board and can be invoked in your sandbox using make check within the docs/ folder.

And subsequent what the best practices are to ensure all links between doc projects are good?

The common practice is to fix forward, by submitting patches like this one. There is also a job on Jenkins called rebuild_all_docs, which will re-build all the docs across all projects. Amongst other use cases, it can be used as a super linkchecker if you like the idea.

@amotl amotl merged commit 8ebaa06 into main May 8, 2025
4 checks passed
@amotl amotl deleted the no-cloud-on-kubernetes branch May 8, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants