-
Notifications
You must be signed in to change notification settings - Fork 672
getActionMenuItems and actionMenuItems can be dependent on an element #17415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
i-just
wants to merge
171
commits into
5.x
Choose a base branch
from
bugfix/17404-matrix-field-copy-all-action-menu-item-part2
base: 5.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
getActionMenuItems and actionMenuItems can be dependent on an element #17415
i-just
wants to merge
171
commits into
5.x
from
bugfix/17404-matrix-field-copy-all-action-menu-item-part2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip]
[ci skip]
…e-all-button-for-matrix-fields “Expand/Collapse all blocks” for inline-editable Matrix fields
[ci skip]
[ci skip]
[ci skip]
[ci skip]
…ition-user-preference “Notification Position” and “Slideout Position” user preferences
Resolves #9960
# Conflicts: # src/config/app.php # src/web/assets/cp/dist/css/cp.css # src/web/assets/cp/dist/css/cp.css.map
[ci skip]
[ci skip]
…-verification-workflow Better email verification workflow
# Conflicts: # src/web/assets/cp/dist/css/cp.css # src/web/assets/cp/dist/css/cp.css.map
…s-event # Conflicts: # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map
[ci skip]
…put-applySettings-event add EntryTypeSelectInput applySettings
# Conflicts: # src/config/app.php # src/web/assets/cp/dist/css/cp.css # src/web/assets/cp/dist/css/cp.css.map
# Conflicts: # src/config/app.php # src/web/assets/cp/dist/css/cp.css # src/web/assets/cp/dist/css/cp.css.map
[ci skip]
…card-view-designers # Conflicts: # src/templates/_includes/forms/button.twig # src/templates/_includes/forms/buttonGroup.twig # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map # src/web/assets/cp/dist/css/cp.css # src/web/assets/cp/dist/css/cp.css.map # src/web/assets/cp/src/js/FieldLayoutDesigner.js # src/web/assets/garnish/dist/garnish.js # src/web/assets/garnish/dist/garnish.js.map
[ci skip]
[ci skip]
…ent-setting-for-card-view-designers Feature/cms 1411 thumb alignment setting for card view designers
Yeah, this needs to wait. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow
$element
and$static
to be passed to the field’sgetActionMenuItems()
andactionMenuItems()
so that action menu items can be added depending on whether the field is in an Element context or not.As it’s potentially a breaking change, we might actually have to target v6?
Related issues
#17404
More info & context: #17416