Skip to content

getActionMenuItems and actionMenuItems can be dependent on an element #17415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 171 commits into
base: 5.x
Choose a base branch
from

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Jun 10, 2025

Description

Allow $element and $static to be passed to the field’s getActionMenuItems() and actionMenuItems() so that action menu items can be added depending on whether the field is in an Element context or not.

As it’s potentially a breaking change, we might actually have to target v6?

Related issues

#17404
More info & context: #17416

brandonkelly and others added 30 commits April 21, 2025 10:19
[ci skip]
…e-all-button-for-matrix-fields

“Expand/Collapse all blocks” for inline-editable Matrix fields
[ci skip]
…ition-user-preference

“Notification Position” and “Slideout Position” user preferences
brandonkelly and others added 26 commits May 31, 2025 11:07
# Conflicts:
#	src/config/app.php
#	src/web/assets/cp/dist/css/cp.css
#	src/web/assets/cp/dist/css/cp.css.map
[ci skip]
…-verification-workflow

Better email verification workflow
# Conflicts:
#	src/web/assets/cp/dist/css/cp.css
#	src/web/assets/cp/dist/css/cp.css.map
…s-event

# Conflicts:
#	src/web/assets/cp/dist/cp.js
#	src/web/assets/cp/dist/cp.js.map
[ci skip]
…put-applySettings-event

add EntryTypeSelectInput applySettings
# Conflicts:
#	src/config/app.php
#	src/web/assets/cp/dist/css/cp.css
#	src/web/assets/cp/dist/css/cp.css.map
# Conflicts:
#	src/config/app.php
#	src/web/assets/cp/dist/css/cp.css
#	src/web/assets/cp/dist/css/cp.css.map
…card-view-designers

# Conflicts:
#	src/templates/_includes/forms/button.twig
#	src/templates/_includes/forms/buttonGroup.twig
#	src/web/assets/cp/dist/cp.js
#	src/web/assets/cp/dist/cp.js.map
#	src/web/assets/cp/dist/css/cp.css
#	src/web/assets/cp/dist/css/cp.css.map
#	src/web/assets/cp/src/js/FieldLayoutDesigner.js
#	src/web/assets/garnish/dist/garnish.js
#	src/web/assets/garnish/dist/garnish.js.map
[ci skip]
…ent-setting-for-card-view-designers

Feature/cms 1411 thumb alignment setting for card view designers
@brandonkelly
Copy link
Member

As it’s potentially a breaking change, we might actually have to target v6?

Yeah, this needs to wait.

@brandonkelly brandonkelly changed the base branch from 5.8 to 5.x July 1, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants