[4.x][5.x] Fixed condition rules losing their condition when being created #16676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip]
brandonkelly
deleted the
bugfix/condition-rule-creation-losing-condition-attribute
branch
|
@nfourtythree Thanks! Craft 4.14.5 and 5.6.6 are out with this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tracking through the creation of a condition rule. The condition is set in the config when creating a rule on a condition (mostly applicable in
5.x) however the condition can be lost when creating the new config for the rule.This means when the new rule class is created it does not have the condition available.
This PR is applicable for both
4.xand5.x.Related issues
craftcms/commerce#3890