Skip to content

added non-json response to actionSendActivationEmail #13071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Apr 11, 2023

Description

If for whatever reason activation emails won't send successfully (e.g. a misconfigured Email setting), any selected checkboxes on the Permissions tab are cleared, which can cause issues if the user is then saved without reloading the page or reselecting the desired permissions.

Return asSuccess/asFailure if the request accepts json; otherwise, redirect back to prevent the above from happening.

Related issues

#13061

@i-just i-just requested a review from a team as a code owner April 11, 2023 12:43
@brandonkelly brandonkelly deleted the bugfix/13061-activation-email-response branch April 11, 2023 22:12
@brandonkelly
Copy link
Member

Source of the bug was that the templates were just checking if it was a post request, rather than specifically a post request to the users/save-user action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants