Escape posted “shortcodes” #13036
Merged
Escape posted “shortcodes” #13036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEV-1104 Escape posted “shortcodes”
“Shortcodes” that are explicitly posted to Plain Text fields and textual cells within Table fields should be escaped, so they don’t get converted to emoji. |
[ci skip]
This was referenced Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
normalizeValueFromRequest()method to field types, which will be called instead ofnormalizeValue()for values set on an element via a request’s post data.(The base implementation in
craft\base\Fieldjust calls$this->normalizeValue()internally, so this is not a breaking change for existing field types.)Plain Text and Table fields take advantage of the new method to avoid automatically converting things that look like shortcodes into emoji (#12935). They also now escape any unconverted shortcodes when serializing their values for the DB, so they won’t be confused for emoji shortcodes the next time the stored value is normalized.
Matrix fields have also been updated so that their sub-fields’
normalizeValueFromRequest()methods are called rather thannormalizeValue(), when appropriate. (This change will need to be applied to Neo and Super Table as well.)Related issues