Skip to content

entry manager per field instance #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Apr 4, 2025

Description

Issue:
Saving nested element changes against the owner’s draft doesn’t work as expected with multi-instance fields.

Screen.Recording.2025-04-04.at.11.39.37.mov

Steps to reproduce:

  • CMS 5.6+ and CKEditor 4.6.0
  • create a text entry type; it can contain simply the default title
  • create a CKEditor config with the “New entry” button and select text entry type under “Entry Types”
  • create a CKEditor field that uses this config
  • create a section (all default settings) with a new entry type that has two instances of the CKEditor field from the previous step included twice
  • create an entry in this section, in each CKE field add one nested entry & fully save everything
  • edit the nested entry in the second cke field on the page, save and then save the root entry - changes are discarded when the root element is saved
  • swap the fields around in the entry type
  • edit the nested entry in the second cke field on the page, save and then save the root entry - changes are discarded when the root element is saved
  • if you edit whichever field is first on the page, it’ll work as expected, regardless of whether it has an overwritten handle or not

Solution:
Create nested element manager on per-instance basis.

Related issues

n/a, reported by @tommysvr

@brandonkelly brandonkelly deleted the bugfix/multi-instance-fields-and-nested-element-changes branch April 6, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant