-
Notifications
You must be signed in to change notification settings - Fork 72
Refactor/agent types #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Refactor/agent types #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
Agent
andParallelAgent
distinct types. This is becauseAgent.act(state)
accepts aState
whereasParallelAgent(state_array)
accepts aStateArray
, meaning that one cannot be substituted for the other, i.e. the Liskov substitution principle is violated if they are treated as the same type. Similarly, this has the ripple effect of makingPreset
andParallelPreset
distinct types, as well asPresetBuilder
andParallelPresetBuilder
.There are also a few other minor changes:
PresetBuilder
objects imported by users are instansiated by default. E.g., what was previouslya2c().device('cuda')
should now be writtena2c.device('cuda')
.name
attribute is now passed from theBuilder
to thePreset
, which will be used to improve logging.Preset
base classes were extended to store thename
,device
, andhyperparameter
attributes which are shared across all presets, improving code reuse.