chore: scaffold copilot-instructions & memory-databank #5413
+5,466
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
|
louis-bompart
commented
Jun 6, 2025
There was a problem hiding this comment.
Let's nix this, I think it's not that useful.
louis-bompart
commented
Jun 6, 2025
| - **Nx**: Workspace management and build orchestration | ||
| - **ESBuild**: Fast JavaScript bundling | ||
| - **TypeScript**: Primary language with custom transformers | ||
| - **Stencil**: Web component compilation (Atomic) |
There was a problem hiding this comment.
Let's add a note about Lit
louis-bompart
commented
Jun 6, 2025
There was a problem hiding this comment.
That's Headless specific
louis-bompart
commented
Jun 6, 2025
|
|
||
| ## Testing Strategy | ||
|
|
||
| ### Unit Tests (Jest) |
There was a problem hiding this comment.
Let's indicate what's the legacy stock, what's the "new standard"
louis-bompart
commented
Jun 6, 2025
Comment on lines
+51
to
+61
| ### Stencil Development | ||
|
|
||
| **Problem**: Changes to Stencil components not reflecting in dev mode. | ||
|
|
||
| **Solution**: | ||
|
|
||
| - Use `--stencil` flag when developing Stencil components | ||
| - Stencil files require special build process | ||
| - Make sure both Atomic and Headless are running in dev mode | ||
|
|
||
| **Command**: `npx nx run atomic:dev --stencil` |
There was a problem hiding this comment.
Let's keep info about stencil light
louis-bompart
commented
Jun 6, 2025
Comment on lines
+14
to
+17
| ```bash | ||
| # Manual unlock (requires admin access) | ||
| node utils/ci/lock-master.mjs | ||
| ``` |
There was a problem hiding this comment.
Or just ask an admin to go to https://github.com/coveo/ui-kit/settings/rules/215874 and flip the switch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt of memory-databank & copilot-instructions setup