chore:improving subscription cleanup and lifecycle management #5170
+32
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Memory Leaks and Detached Nodes by Improving Subscription Cleanup and Lifecycle Management
Remove Hard references
Previously, when
console.error
logs the entire component object, it creates a reference to the component. This reference prevents the garbage collector from reclaiming the memory associated with the component, even after it has been removed from the DOM. This results in a detached node.The solution is to not pass the reference of component to console.error. Instead, only log the tag name
Controller subscription not cleaned up
Overriding the
disconnectedCallback
seems to conflicts with other mixins or decorators.Instead of doing that (which is kinda hackish anyway), I created a reactive controller which automatically hooks itself to lit reactive system.
Image showing detached nodes because of bad cleaning...

https://coveord.atlassian.net/browse/KIT-4099