Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(atomic): migrate atomic-commerce-interface to Lit #5017

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

fpbrault
Copy link
Contributor

@fpbrault fpbrault commented Feb 27, 2025

Atomic Commerce Interface Component Specification

📝 Requirements

The atomic-commerce-interface component is designed to the parent to other atomic commerce components in a commerce page.

  • It handles the headless commerce engine and localization configurations
  • Used for all atomic commerce components (except for atomic-commerce-recommendation-list, which must have atomic-commerce-recommendation-interface as a parent)
  • Can be initialized with an already existing engine, or initialize a new one.
  • Handles initialization of child components when ready (and queue their initialization event when not yet ready)
  • Can store the state in the url using the URL manager
  • Can provide the bindings to other components through context

♿ Accessibility

  • Adds the atomic-aria-live element to the DOM, which is used for aria-live messages

✅ Checklist

  • 🧪 The component is unit tested
  • 🧪 The component includes E2E tests
  • 🗑️ Old Cypress tests exclusive to the component are removed
  • ♿ The component complies with the Web Content Accessibility Guidelines.
  • 🌐 All strings intended for humans or assistive technology must be localized with i18n.
  • 📦 The Lit component is exported in the appropriate index.ts and lazy-index.ts files.
  • 🎨 CSS parts are documented still accessible.
  • 🦥 Slotted Content, public methods and properties are documented

https://coveord.atlassian.net/browse/KIT-3932

Copy link

github-actions bot commented Feb 27, 2025

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 248.6 248.6 0
commerce 361 361 0
search 419.6 419.6 0
insight 410.8 410.8 0
recommendation 259.5 259.5 0
ssr 413.4 413.4 0
ssr-commerce 377.5 377.5 0

@fpbrault fpbrault changed the base branch from master to KIT-4005 February 28, 2025 16:23
@fpbrault fpbrault force-pushed the KIT-4005 branch 3 times, most recently from b29b61c to 1b39b93 Compare March 14, 2025 21:36
Base automatically changed from KIT-4005 to master March 16, 2025 17:10
@fpbrault fpbrault changed the base branch from master to KIT-4050 March 17, 2025 15:27
@fpbrault fpbrault force-pushed the KIT-4050 branch 2 times, most recently from d585c51 to e2ae1fe Compare March 18, 2025 18:36
fpbrault and others added 15 commits April 14, 2025 10:15
https://coveord.atlassian.net/browse/KIT-3932

use non-stencil getAssetPath

https://coveord.atlassian.net/browse/KIT-3932

remove log

https://coveord.atlassian.net/browse/KIT-3932

smaller styles

https://coveord.atlassian.net/browse/KIT-3932

remove unused styles

https://coveord.atlassian.net/browse/KIT-3932

add missing generated files

https://coveord.atlassian.net/browse/KIT-3932

fix build

https://coveord.atlassian.net/browse/KIT-3932

cleanup

https://coveord.atlassian.net/browse/KIT-3932

other approach for loader

https://coveord.atlassian.net/browse/KIT-3932

cleanup

https://coveord.atlassian.net/browse/KIT-3932

create bindings decorator

https://coveord.atlassian.net/browse/KIT-4005

fix bindings

https://coveord.atlassian.net/browse/KIT-4005

add commerce page to angular sample

https://coveord.atlassian.net/browse/KIT-3932

fix interface init

https://coveord.atlassian.net/browse/KIT-3932

revert setup

https://coveord.atlassian.net/browse/KIT-3932

revert loader change

https://coveord.atlassian.net/browse/KIT-3932

restore coveoglobal for lit interface

https://coveord.atlassian.net/browse/KIT-3932

fix init

https://coveord.atlassian.net/browse/KIT-3932

fix story

https://coveord.atlassian.net/browse/KIT-3932

fix missing global version

https://coveord.atlassian.net/browse/KIT-3932

cleanup

https://coveord.atlassian.net/browse/KIT-3932

fix cdn build

https://coveord.atlassian.net/browse/KIT-3932

fix components

https://coveord.atlassian.net/browse/KIT-3932

fix build

https://coveord.atlassian.net/browse/KIT-3932

add commerce angular smoke test

https://coveord.atlassian.net/browse/KIT-3932

fix unit tests

https://coveord.atlassian.net/browse/KIT-3932

lint fix

https://coveord.atlassian.net/browse/KIT-3932

fallback to ts if no tsx exists

https://coveord.atlassian.net/browse/KIT-3932

fix test generation

https://coveord.atlassian.net/browse/KIT-3932

fix interface

https://coveord.atlassian.net/browse/KIT-3932

fix for storybook?

https://coveord.atlassian.net/browse/KIT-3932

move initAriaLive to connectedCallback

https://coveord.atlassian.net/browse/KIT-3932

restore e2e tests

https://coveord.atlassian.net/browse/KIT-3932

add arbitrary delay before first request for storybook

https://coveord.atlassian.net/browse/KIT-3932

remove withresolvers

https://coveord.atlassian.net/browse/KIT-3932

remove cspnonce

https://coveord.atlassian.net/browse/KIT-3932

Add generated files

add atomic-commerce-url-manager

https://coveord.atlassian.net/browse/KIT-3932

fix tests

https://coveord.atlassian.net/browse/KIT-3932

handle region locale

https://coveord.atlassian.net/browse/KIT-3932

different approach for url manager

https://coveord.atlassian.net/browse/KIT-3932

add ChildrenUpdateCompleteMixin mixin

https://coveord.atlassian.net/browse/KIT-4073

use ChildrenUpdateCompleteMixin

https://coveord.atlassian.net/browse/KIT-3932

fix mixin

https://coveord.atlassian.net/browse/KIT-3932

fix test

https://coveord.atlassian.net/browse/KIT-3932

remove timeouts

https://coveord.atlassian.net/browse/KIT-3932
Signed-off-by: Felix Perron-Brault <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants