fix(headless): move facet display reg. tabs to the facet condition manager #30002
prbot.yml
on: pull_request
Build
8m 54s
Build Windows
36m 18s
Build CDN
7m 17s
PR Report
5m 25s
Verify compatibility of packages
6m 43s
Matrix: Run e2e tests on Atomic
Run Quantic E2E tests
/
Setup e2e tests on Quantic
13m 12s
Run e2e screenshots tests on Atomic
8m 4s
Run e2e tests on Atomic React
8m 48s
Run e2e tests on Atomic React NextJS
8m 2s
Run e2e tests for IIFE
14s
Run e2e tests on Atomic Angular
8m 52s
Run e2e tests on Vue.js sample
6m 54s
Run e2e tests on Stencil.js sample
7m 39s
Run e2e tests for Atomic Hosted Page
9m 40s
Run e2e tests for Headless Commerce SSR
10m 21s
Run e2e tests on Atomic insight panel
8m 41s
Run e2e tests on Headless SSR App router sample
8m 9s
Run e2e tests on Headless SSR Pages router sample
8m 13s
CDN Checks
7m 6s
Build typedoc
7m 50s
Run theming smoke tests for Atomic
11m 13s
Matrix: Run Quantic E2E tests / Run Playwright e2e tests on Quantic
Matrix: Run Quantic E2E tests / Run Cypress e2e tests on Quantic
Matrix: Run Playwright tests for Atomic
Run Quantic E2E tests
/
Merge Playwright reports
6m 59s
Merge Playwright reports
7m 42s
Confirm build is valid
11s
Annotations
13 errors and 2 notices
[chromium] › src/components/commerce/atomic-commerce-search-box-recent-queries/e2e/atomic-commerce-search-box-recent-queries.e2e.ts:29:3 › AtomicCommerceSearchBoxRecentQueries › when clicking clear recent queries:
packages/atomic/src/components/commerce/atomic-commerce-search-box-recent-queries/e2e/atomic-commerce-search-box-recent-queries.e2e.ts#L32
1) [chromium] › src/components/commerce/atomic-commerce-search-box-recent-queries/e2e/atomic-commerce-search-box-recent-queries.e2e.ts:29:3 › AtomicCommerceSearchBoxRecentQueries › when clicking clear recent queries, it should clear the recent queries
Error: locator.click: Error: strict mode violation: getByLabel('Clear recent searches.') resolved to 2 elements:
1) <button aria-label="Clear recent searches. 1 of 9." part="suggestion recent-query-title-item suggestion-divider" id="atomic-commerce-search-box-jk1o3-left-suggestion-recent-query-clear" class="flex px-4 min-h-10 items-center text-left text-neutral-dark cursor-pointer">…</button> aka getByRole('button', { name: 'Clear recent searches. 1 of' })
2) <button aria-label="Clear recent searches. 3 of 9." part="suggestion recent-query-title-item suggestion-divider" id="atomic-commerce-search-box-jk1o3-left-suggestion-recent-query-clear" class="flex px-4 min-h-10 items-center text-left text-neutral-dark cursor-pointer">…</button> aka getByRole('button', { name: 'Clear recent searches. 3 of' })
Call log:
- waiting for getByLabel('Clear recent searches.')
30 | commerceSearchBoxRecentQueries,
31 | }) => {
> 32 | await commerceSearchBoxRecentQueries.clearButton.click();
| ^
33 | await expect(commerceSearchBoxRecentQueries.recentQuery).toHaveCount(0);
34 | });
35 | });
at /home/runner/work/ui-kit/ui-kit/packages/atomic/src/components/commerce/atomic-commerce-search-box-recent-queries/e2e/atomic-commerce-search-box-recent-queries.e2e.ts:32:54
|
[chromium] › src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:169:11 › AtomicTabManager › when viewport is large enough to display all tabs › when clicking on tab button › when selecting previous tab › should change other component visibility › facets:
packages/atomic/src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts#L177
3) [chromium] › src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:169:11 › AtomicTabManager › when viewport is large enough to display all tabs › when clicking on tab button › when selecting previous tab › should change other component visibility › facets
Error: Timed out 7000ms waiting for expect(locator).toBeHidden()
Locator: getByLabel(/^included-facet$/).first()
Expected: hidden
Received: visible
Call log:
- expect.toBeHidden with timeout 7000ms
- waiting for getByLabel(/^included-facet$/).first()
11 × locator resolved to <atomic-facet with-search="" field="filetype" class="hydrated" heading-level="0" facet-id="filetype" number-of-values="8" filter-facet-count="" data-atomic-loaded="true" sort-criteria="automatic" aria-label="included-facet" tabs-included="["article"]" data-atomic-rendered="true" display-values-as="checkbox" label="File type (included facet)" results-must-match="atLeastOneValue"></atomic-facet>
- unexpected value "visible"
175 | const includedFacets = await tabManager.includedFacet.all();
176 | for (let i = 0; i < includedFacets.length; i++) {
> 177 | await expect(includedFacets[i]).toBeHidden();
| ^
178 | }
179 | });
180 |
at /home/runner/work/ui-kit/ui-kit/packages/atomic/src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:177:47
|
[chromium] › src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:116:9 › AtomicTabManager › when viewport is large enough to display all tabs › when clicking on tab button › should change other component visibility › facets:
packages/atomic/src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts#L117
2) [chromium] › src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:116:9 › AtomicTabManager › when viewport is large enough to display all tabs › when clicking on tab button › should change other component visibility › facets
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Error: locator.waitFor: Test timeout of 30000ms exceeded.
Call log:
- waiting for getByLabel(/^excluded-facet$/).last() to be hidden
61 × locator resolved to visible <atomic-segmented-facet label="Kingdom" class="hydrated" field="inat_kingdom" number-of-values="6" filter-facet-count="" data-atomic-loaded="true" sort-criteria="automatic" facet-id="inat_kingdom_1" aria-label="excluded-facet" tabs-excluded="["article"]" data-atomic-rendered="true"></atomic-segmented-facet>
115 | test.describe('should change other component visibility', async () => {
116 | test('facets', async ({tabManager}) => {
> 117 | await tabManager.excludedFacet.last().waitFor({state: 'hidden'});
| ^
118 | const includedFacets = await tabManager.includedFacet.all();
119 | for (let i = 0; i < includedFacets.length; i++) {
120 | await expect(includedFacets[i]).toBeVisible();
at /home/runner/work/ui-kit/ui-kit/packages/atomic/src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:117:49
|
[chromium] › src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:116:9 › AtomicTabManager › when viewport is large enough to display all tabs › when clicking on tab button › should change other component visibility › facets:
packages/atomic/src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts#L0
2) [chromium] › src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:116:9 › AtomicTabManager › when viewport is large enough to display all tabs › when clicking on tab button › should change other component visibility › facets
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Test timeout of 30000ms exceeded.
|
[chromium] › src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:116:9 › AtomicTabManager › when viewport is large enough to display all tabs › when clicking on tab button › should change other component visibility › facets:
packages/atomic/src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts#L117
2) [chromium] › src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:116:9 › AtomicTabManager › when viewport is large enough to display all tabs › when clicking on tab button › should change other component visibility › facets
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: locator.waitFor: Test timeout of 30000ms exceeded.
Call log:
- waiting for getByLabel(/^excluded-facet$/).last() to be hidden
61 × locator resolved to visible <atomic-segmented-facet label="Kingdom" class="hydrated" field="inat_kingdom" number-of-values="6" filter-facet-count="" facet-id="inat_kingdom" data-atomic-loaded="true" sort-criteria="automatic" aria-label="excluded-facet" tabs-excluded="["article"]" data-atomic-rendered="true"></atomic-segmented-facet>
115 | test.describe('should change other component visibility', async () => {
116 | test('facets', async ({tabManager}) => {
> 117 | await tabManager.excludedFacet.last().waitFor({state: 'hidden'});
| ^
118 | const includedFacets = await tabManager.includedFacet.all();
119 | for (let i = 0; i < includedFacets.length; i++) {
120 | await expect(includedFacets[i]).toBeVisible();
at /home/runner/work/ui-kit/ui-kit/packages/atomic/src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:117:49
|
[chromium] › src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:116:9 › AtomicTabManager › when viewport is large enough to display all tabs › when clicking on tab button › should change other component visibility › facets:
packages/atomic/src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts#L0
2) [chromium] › src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:116:9 › AtomicTabManager › when viewport is large enough to display all tabs › when clicking on tab button › should change other component visibility › facets
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Test timeout of 30000ms exceeded.
|
[chromium] › src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:116:9 › AtomicTabManager › when viewport is large enough to display all tabs › when clicking on tab button › should change other component visibility › facets:
packages/atomic/src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts#L117
2) [chromium] › src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:116:9 › AtomicTabManager › when viewport is large enough to display all tabs › when clicking on tab button › should change other component visibility › facets
Error: locator.waitFor: Test timeout of 30000ms exceeded.
Call log:
- waiting for getByLabel(/^excluded-facet$/).last() to be hidden
61 × locator resolved to visible <atomic-segmented-facet label="Kingdom" class="hydrated" field="inat_kingdom" number-of-values="6" filter-facet-count="" data-atomic-loaded="true" sort-criteria="automatic" facet-id="inat_kingdom_1" aria-label="excluded-facet" tabs-excluded="["article"]" data-atomic-rendered="true"></atomic-segmented-facet>
115 | test.describe('should change other component visibility', async () => {
116 | test('facets', async ({tabManager}) => {
> 117 | await tabManager.excludedFacet.last().waitFor({state: 'hidden'});
| ^
118 | const includedFacets = await tabManager.includedFacet.all();
119 | for (let i = 0; i < includedFacets.length; i++) {
120 | await expect(includedFacets[i]).toBeVisible();
at /home/runner/work/ui-kit/ui-kit/packages/atomic/src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:117:49
|
[chromium] › src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:116:9 › AtomicTabManager › when viewport is large enough to display all tabs › when clicking on tab button › should change other component visibility › facets:
packages/atomic/src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts#L0
2) [chromium] › src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:116:9 › AtomicTabManager › when viewport is large enough to display all tabs › when clicking on tab button › should change other component visibility › facets
Test timeout of 30000ms exceeded.
|
[chromium] › src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:50:7 › AtomicTabManager › when viewport is large enough to display all tabs › should change other component visibility › facets:
packages/atomic/src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts#L53
1) [chromium] › src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:50:7 › AtomicTabManager › when viewport is large enough to display all tabs › should change other component visibility › facets
Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
Error: Timed out 7000ms waiting for expect(locator).toBeHidden()
Locator: getByLabel(/^included-facet$/).first()
Expected: hidden
Received: visible
Call log:
- expect.toBeHidden with timeout 7000ms
- waiting for getByLabel(/^included-facet$/).first()
11 × locator resolved to <atomic-facet with-search="" field="filetype" class="hydrated" heading-level="0" facet-id="filetype" number-of-values="8" filter-facet-count="" data-atomic-loaded="true" sort-criteria="automatic" aria-label="included-facet" tabs-included="["article"]" data-atomic-rendered="true" display-values-as="checkbox" label="File type (included facet)" results-must-match="atLeastOneValue"></atomic-facet>
- unexpected value "visible"
51 | const includedFacets = await tabManager.includedFacet.all();
52 | for (let i = 0; i < includedFacets.length; i++) {
> 53 | await expect(includedFacets[i]).toBeHidden();
| ^
54 | }
55 |
56 | const excludedFacets = await tabManager.excludedFacet.all();
at /home/runner/work/ui-kit/ui-kit/packages/atomic/src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:53:43
|
[chromium] › src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:50:7 › AtomicTabManager › when viewport is large enough to display all tabs › should change other component visibility › facets:
packages/atomic/src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts#L53
1) [chromium] › src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:50:7 › AtomicTabManager › when viewport is large enough to display all tabs › should change other component visibility › facets
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Timed out 7000ms waiting for expect(locator).toBeHidden()
Locator: getByLabel(/^included-facet$/).first()
Expected: hidden
Received: visible
Call log:
- expect.toBeHidden with timeout 7000ms
- waiting for getByLabel(/^included-facet$/).first()
11 × locator resolved to <atomic-facet with-search="" field="filetype" class="hydrated" heading-level="0" facet-id="filetype" number-of-values="8" filter-facet-count="" data-atomic-loaded="true" sort-criteria="automatic" aria-label="included-facet" tabs-included="["article"]" data-atomic-rendered="true" display-values-as="checkbox" label="File type (included facet)" results-must-match="atLeastOneValue"></atomic-facet>
- unexpected value "visible"
51 | const includedFacets = await tabManager.includedFacet.all();
52 | for (let i = 0; i < includedFacets.length; i++) {
> 53 | await expect(includedFacets[i]).toBeHidden();
| ^
54 | }
55 |
56 | const excludedFacets = await tabManager.excludedFacet.all();
at /home/runner/work/ui-kit/ui-kit/packages/atomic/src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:53:43
|
[chromium] › src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:50:7 › AtomicTabManager › when viewport is large enough to display all tabs › should change other component visibility › facets:
packages/atomic/src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts#L53
1) [chromium] › src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:50:7 › AtomicTabManager › when viewport is large enough to display all tabs › should change other component visibility › facets
Error: Timed out 7000ms waiting for expect(locator).toBeHidden()
Locator: getByLabel(/^included-facet$/).first()
Expected: hidden
Received: visible
Call log:
- expect.toBeHidden with timeout 7000ms
- waiting for getByLabel(/^included-facet$/).first()
11 × locator resolved to <atomic-facet with-search="" field="filetype" class="hydrated" heading-level="0" facet-id="filetype" number-of-values="8" filter-facet-count="" data-atomic-loaded="true" sort-criteria="automatic" aria-label="included-facet" tabs-included="["article"]" data-atomic-rendered="true" display-values-as="checkbox" label="File type (included facet)" results-must-match="atLeastOneValue"></atomic-facet>
- unexpected value "visible"
51 | const includedFacets = await tabManager.includedFacet.all();
52 | for (let i = 0; i < includedFacets.length; i++) {
> 53 | await expect(includedFacets[i]).toBeHidden();
| ^
54 | }
55 |
56 | const excludedFacets = await tabManager.excludedFacet.all();
at /home/runner/work/ui-kit/ui-kit/packages/atomic/src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:53:43
|
Confirm build is valid (PR)
Process completed with exit code 1.
|
Confirm build is valid
Process completed with exit code 1.
|
🎭 Playwright Run Summary
1 flaky
[chromium] › src/components/commerce/atomic-commerce-search-box-recent-queries/e2e/atomic-commerce-search-box-recent-queries.e2e.ts:29:3 › AtomicCommerceSearchBoxRecentQueries › when clicking clear recent queries, it should clear the recent queries
50 passed (1.8m)
|
🎭 Playwright Run Summary
5 failed
[chromium] › src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:50:7 › AtomicTabManager › when viewport is large enough to display all tabs › should change other component visibility › facets
[chromium] › src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:116:9 › AtomicTabManager › when viewport is large enough to display all tabs › when clicking on tab button › should change other component visibility › facets
[chromium] › src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:169:11 › AtomicTabManager › when viewport is large enough to display all tabs › when clicking on tab button › when selecting previous tab › should change other component visibility › facets
[chromium] › src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:347:9 › AtomicTabManager › when viewport is too small to display all buttons › when selecting a tab popover button › should change other component visibility › facets
[chromium] › src/components/search/tabs/atomic-tab-manager/e2e/atomic-tab-manager.e2e.ts:403:11 › AtomicTabManager › when viewport is too small to display all buttons › when selecting a tab popover button › when selecting another tab in popover buttons › should change other component visibility › facets
5 skipped
40 passed (5.8m)
|
Artifacts
Produced during runtime
Name | Size | Digest | |
---|---|---|---|
atomic-blob-report-12
Expired
|
21.5 MB |
sha256:fc1364ed89b0b0f592192fc8f7e0f775d61cb778a5d3a0b95ee7fe0d50c8b2d6
|
|
atomic-blob-report-5
Expired
|
334 KB |
sha256:4934d747375394851e225b8c7f31429d0f54c2345bda3c52140772247e810df0
|
|
atomic-playwright-report
Expired
|
23.4 MB |
sha256:ca99064eb7764e200750184e3dfd50844c521eea475971c0b25cf3b3fb3f1438
|
|