Skip to content

feat(modeldetails): removal of recommendationsPerLanguage following d… #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lprovost-coveo
Copy link
Contributor

…eprecation

Removing after giving notice for 3 months

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will follow the commit guidelines (See Commit Guidelines)

Copy link
Contributor

@FelixBlaisThon FelixBlaisThon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a breaking change ?

@lprovost-coveo
Copy link
Contributor Author

Should this be a breaking change ?
I thought about that but since the property was nullable if someone did indeed pull on this (other than ADUI * no uses there anymore) they would have a null check for the property, but I don't think anyone used this for anything, It's a bit aggressive to turn this into a major no?

Copy link
Contributor

@y-lakhdar y-lakhdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure how widely this property was used, but it does seem like a breaking change. Given that, I’m not convinced it should be released under a minor version bump. Would it be possible to include this in a future major release instead?

Also, I ran a search for @deprecated in the codebase and noticed several others. Perhaps we could consider grouping these deprecations and removals into a coordinated major release?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants